From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eryu Guan <eguan@redhat.com>
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH] xfs/015: enlarge the initial fs size
Date: Wed, 14 Feb 2018 08:45:32 -0800 [thread overview]
Message-ID: <20180214164532.GH5217@magnolia> (raw)
In-Reply-To: <20180214152401.GO18267@eguan.usersys.redhat.com>
On Wed, Feb 14, 2018 at 11:24:01PM +0800, Eryu Guan wrote:
> On Thu, Jan 04, 2018 at 01:46:26PM +0800, Eryu Guan wrote:
> > Kernel commit f59cf5c29919 ("xfs: remove "no-allocation"
> > reservations for file creations") is known to cause earlier ENOSPC
> > conditions, and xfs/015 is affected in the way that no new file/dir
> > can be created in a newly created 16M XFS with both reflink and
> > rmapbt enabled, thus xfs/015 fails due to the missing test dirs.
> >
> > So enlarge the initial fs size to 32M that we're able to create new
32M? I thought this was a 64M -> 128M expansion?
> > dir/file before growing the filesystem size.
> >
> > Signed-off-by: Eryu Guan <eguan@redhat.com>
I don't think this hurts anything, but otoh I couldn't reproduce the
failure you're seeing on my setup.
--D
>
> ping on this patch.
>
> Eryu
>
> > ---
> > tests/xfs/015 | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/tests/xfs/015 b/tests/xfs/015
> > index 2c57f7882308..4939bb92f6fc 100755
> > --- a/tests/xfs/015
> > +++ b/tests/xfs/015
> > @@ -66,15 +66,15 @@ _supported_os Linux
> >
> > _require_scratch
> >
> > -# need 64M space, don't make any assumption
> > +# need 128M space, don't make any assumption
> > _scratch_mkfs >/dev/null 2>&1
> > _scratch_mount
> > -_require_fs_space $SCRATCH_MNT 65536
> > +_require_fs_space $SCRATCH_MNT 131072
> > _scratch_unmount
> >
> > rm -f $seqres.full
> >
> > -_scratch_mkfs_sized $((16 * 1024 * 1024)) > $tmp.mkfs.raw
> > +_scratch_mkfs_sized $((32 * 1024 * 1024)) > $tmp.mkfs.raw
> > cat $tmp.mkfs.raw | _filter_mkfs >$seqres.full 2>$tmp.mkfs
> > # get original data blocks number and agcount
> > . $tmp.mkfs
> > --
> > 2.14.3
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-02-14 16:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 5:46 [PATCH] xfs/015: enlarge the initial fs size Eryu Guan
2018-02-14 15:24 ` Eryu Guan
2018-02-14 16:45 ` Darrick J. Wong [this message]
2018-02-15 8:33 ` Eryu Guan
2018-02-15 16:39 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180214164532.GH5217@magnolia \
--to=darrick.wong@oracle.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).