From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org, Jeff Layton <jlayton@redhat.com>
Subject: Re: [PATCH] xfs: rewrite the fdatasync optimization
Date: Thu, 15 Feb 2018 09:43:26 +1100 [thread overview]
Message-ID: <20180214224326.GL7000@dastard> (raw)
In-Reply-To: <20180214155343.GA4472@lst.de>
On Wed, Feb 14, 2018 at 04:53:43PM +0100, Christoph Hellwig wrote:
> Ok, for the case where the same file also accessed throught NFS is
> locally written and fdatasync we'll run into an issue.
>
> But we already have the exact same issue on NFSv3 which always uses
> ctime and never looks at iversion.
The NFSv3 server won't be querying the iversion field, so on
upstream kernels it will never change or need to be logged on local
fs accesses. Hence I don't think we need to care about NFSv3 at all
here....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2018-02-14 22:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-05 7:39 [PATCH] xfs: rewrite the fdatasync optimization Christoph Hellwig
2018-02-05 22:17 ` Dave Chinner
2018-02-06 7:23 ` Christoph Hellwig
2018-02-08 23:17 ` Dave Chinner
2018-02-13 15:04 ` Christoph Hellwig
2018-02-13 23:26 ` Dave Chinner
2018-02-14 15:53 ` Christoph Hellwig
2018-02-14 22:43 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180214224326.GL7000@dastard \
--to=david@fromorbit.com \
--cc=hch@lst.de \
--cc=jlayton@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).