From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-nvdimm@lists.01.org, david@fromorbit.com,
linux-xfs@vger.kernel.org, ross.zwisler@linux.intel.com,
linux-ext4@vger.kernel.org, dan.j.williams@intel.com
Subject: Re: [PATCH v4 1/3] fs: allow per-device dax status checking for filesystems
Date: Thu, 15 Feb 2018 11:06:58 -0800 [thread overview]
Message-ID: <20180215190658.GQ5217@magnolia> (raw)
In-Reply-To: <f5f93cd1-4d9e-c794-99fb-28daa0d1669d@intel.com>
On Thu, Feb 15, 2018 at 10:58:54AM -0700, Dave Jiang wrote:
> On 02/15/2018 10:52 AM, Christoph Hellwig wrote:
> >> /**
> >> - * __bdev_dax_supported() - Check if the device supports dax for filesystem
> >> + * bdev_dax_supported() - Check if the device supports dax for filesystem
> >> * @sb: The superblock of the device
> >> + * @bdev: block device to check
> >> * @blocksize: The block size of the device
> >> *
> >> * This is a library function for filesystems to check if the block device
> >> @@ -82,9 +83,9 @@ EXPORT_SYMBOL_GPL(fs_dax_get_by_bdev);
> >> *
> >> * Return: negative errno if unsupported, 0 if supported.
> >> */
> >> -int __bdev_dax_supported(struct super_block *sb, int blocksize)
> >> +int bdev_dax_supported(struct super_block *sb, struct block_device *bdev,
> >> + int blocksize)
> >> {
> >> - struct block_device *bdev = sb->s_bdev;
> >> struct dax_device *dax_dev;
> >> pgoff_t pgoff;
> >> int err, id;
> >
> > This now only uses sb for sb->s_id. It might be better to use bdevname
> > to print the device name and don't bother passing a sb at all.
> >
>
> I think Darrick wanted to keep the API the same for non-XFS users. I'm
> ok with dropping the passed in sb if Darrick has no objections.
Fine with me to use bdevname.
--D
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-02-15 19:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 17:42 [PATCH v4 0/3] minimal DAX support for XFS realtime device Dave Jiang
2018-02-15 17:42 ` [PATCH v4 1/3] fs: allow per-device dax status checking for filesystems Dave Jiang
2018-02-15 17:52 ` Christoph Hellwig
2018-02-15 17:58 ` Dave Jiang
2018-02-15 18:05 ` Christoph Hellwig
2018-02-15 19:06 ` Darrick J. Wong [this message]
2018-03-01 1:22 ` kbuild test robot
2018-02-15 17:42 ` [PATCH v4 2/3] dax: change bdev_dax_supported() to support boolean returns Dave Jiang
2018-02-18 8:22 ` kbuild test robot
2018-02-15 17:42 ` [PATCH v4 3/3] xfs: reject removal of realtime flag when datadev doesn't support DAX Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180215190658.GQ5217@magnolia \
--to=darrick.wong@oracle.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ross.zwisler@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).