From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
Eric Sandeen <sandeen@redhat.com>,
xfs <linux-xfs@vger.kernel.org>,
Nathan Scott <nathans@redhat.com>
Subject: Re: [PATCH] debian: add build-depends on pkg-config
Date: Fri, 16 Feb 2018 08:33:30 +1100 [thread overview]
Message-ID: <20180215213330.GP7000@dastard> (raw)
In-Reply-To: <268bfeb5-f7bf-b2b2-74c3-2c6c74d8b427@sandeen.net>
On Thu, Feb 15, 2018 at 11:02:12AM -0600, Eric Sandeen wrote:
> On 2/15/18 12:51 AM, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Since the configure scripts now depend on pkg-config to autodetect where
> > systemd service files go, we need to list pkg-config as a build
> > dependency.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
>
> I'd love to have a Debian-savvy person look over these things.
I hit this a couple of days ago doing a normal build and having
config fail due to a missing pkg-config package. The build-dep
update looks fine.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2018-02-15 21:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 6:51 [PATCH] debian: add build-depends on pkg-config Darrick J. Wong
2018-02-15 17:02 ` Eric Sandeen
[not found] ` <CAFMei7PkvECcgsuj610O=PsrbqYD3mw0Wnc-Z71n5PZFtRkLYg@mail.gmail.com>
2018-02-15 21:11 ` Eric Sandeen
2018-02-15 21:33 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180215213330.GP7000@dastard \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=nathans@redhat.com \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).