* [PATCH] xfs_db: don't crash in ablock if there's no inode
@ 2018-02-21 3:37 Darrick J. Wong
0 siblings, 0 replies; only message in thread
From: Darrick J. Wong @ 2018-02-21 3:37 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs
From: Darrick J. Wong <darrick.wong@oracle.com>
Make sure we actually have an inode selected before trying to unwrap its
attribute fork. Found via a crash in xfs/288 with project quotas
enabled.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
db/block.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/db/block.c b/db/block.c
index 5ecd687..174e29a 100644
--- a/db/block.c
+++ b/db/block.c
@@ -84,6 +84,11 @@ ablock_f(
}
push_cur();
set_cur_inode(iocur_top->ino);
+ if (!iocur_top->data) {
+ pop_cur();
+ dbprintf(_("no current inode\n"));
+ return 0;
+ }
haveattr = XFS_DFORK_Q((xfs_dinode_t *)iocur_top->data);
pop_cur();
if (!haveattr) {
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2018-02-21 3:37 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-21 3:37 [PATCH] xfs_db: don't crash in ablock if there's no inode Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).