* [PATCH] xfs_scrub: don't ask user to run xfs_repair for only warnings
@ 2018-02-21 3:36 Darrick J. Wong
2018-02-21 12:47 ` Bill O'Donnell
0 siblings, 1 reply; 2+ messages in thread
From: Darrick J. Wong @ 2018-02-21 3:36 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs
From: Darrick J. Wong <darrick.wong@oracle.com>
Don't advise the user to run xfs_repair on a filesystem that triggers
warnings but no errors; there's no corruption for it to fix.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
scrub/xfs_scrub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scrub/xfs_scrub.c b/scrub/xfs_scrub.c
index ab26e63..53a105a 100644
--- a/scrub/xfs_scrub.c
+++ b/scrub/xfs_scrub.c
@@ -514,7 +514,7 @@ report_outcome(
fprintf(stderr, _("%s: errors found: %llu; warnings found: %llu\n"),
ctx->mntpoint, total_errors,
ctx->warnings_found);
- if (ctx->need_repair)
+ if (ctx->need_repair && total_errors > 0)
fprintf(stderr, _("%s: Unmount and run xfs_repair.\n"),
ctx->mntpoint);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs_scrub: don't ask user to run xfs_repair for only warnings
2018-02-21 3:36 [PATCH] xfs_scrub: don't ask user to run xfs_repair for only warnings Darrick J. Wong
@ 2018-02-21 12:47 ` Bill O'Donnell
0 siblings, 0 replies; 2+ messages in thread
From: Bill O'Donnell @ 2018-02-21 12:47 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: Eric Sandeen, xfs
On Tue, Feb 20, 2018 at 07:36:54PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Don't advise the user to run xfs_repair on a filesystem that triggers
> warnings but no errors; there's no corruption for it to fix.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
looks fine.
Reviewed-by: Bill O'Donnell <billodo@redhat.com>
> ---
> scrub/xfs_scrub.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scrub/xfs_scrub.c b/scrub/xfs_scrub.c
> index ab26e63..53a105a 100644
> --- a/scrub/xfs_scrub.c
> +++ b/scrub/xfs_scrub.c
> @@ -514,7 +514,7 @@ report_outcome(
> fprintf(stderr, _("%s: errors found: %llu; warnings found: %llu\n"),
> ctx->mntpoint, total_errors,
> ctx->warnings_found);
> - if (ctx->need_repair)
> + if (ctx->need_repair && total_errors > 0)
> fprintf(stderr, _("%s: Unmount and run xfs_repair.\n"),
> ctx->mntpoint);
> }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-21 12:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-21 3:36 [PATCH] xfs_scrub: don't ask user to run xfs_repair for only warnings Darrick J. Wong
2018-02-21 12:47 ` Bill O'Donnell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).