* [PATCH] xfs_scrub: don't try to scan xattrs if bstat says there aren't any
@ 2018-02-22 2:16 Darrick J. Wong
0 siblings, 0 replies; only message in thread
From: Darrick J. Wong @ 2018-02-22 2:16 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs
From: Darrick J. Wong <darrick.wong@oracle.com>
Only try to scan the extended attributes of a file if bstat says that
the file actually has any. Surprisingly, this reduces the phase 5
runtime by 40% if most of the files don't have attrs.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
scrub/phase5.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/scrub/phase5.c b/scrub/phase5.c
index 703b279..aafa036 100644
--- a/scrub/phase5.c
+++ b/scrub/phase5.c
@@ -259,9 +259,12 @@ xfs_scrub_connections(
background_sleep();
/* Warn about naming problems in xattrs. */
- moveon = xfs_scrub_scan_fhandle_xattrs(ctx, descr, handle, bstat);
- if (!moveon)
- goto out;
+ if (bstat->bs_xflags & FS_XFLAG_HASATTR) {
+ moveon = xfs_scrub_scan_fhandle_xattrs(ctx, descr, handle,
+ bstat);
+ if (!moveon)
+ goto out;
+ }
/* Open the dir, let the kernel try to reconnect it to the root. */
if (S_ISDIR(bstat->bs_mode)) {
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2018-02-22 2:16 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-22 2:16 [PATCH] xfs_scrub: don't try to scan xattrs if bstat says there aren't any Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).