From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Yang Joseph <joseph.yang@xtaotech.com>,
sandeen@redhat.com, nathans@debian.org,
linux-xfs@vger.kernel.org
Subject: Re: xfs_repair: add '-F' option to ignore writable mount checking
Date: Sun, 25 Feb 2018 09:04:28 +1100 [thread overview]
Message-ID: <20180224220428.GB30854@dastard> (raw)
In-Reply-To: <5c0df437-0f09-129c-945f-0f917bfdaa7e@sandeen.net>
On Sat, Feb 24, 2018 at 11:56:44AM -0600, Eric Sandeen wrote:
> On 2/24/18 5:23 AM, Yang Joseph wrote:
> > hello,
> >
> > Before the repair process, xfs_repair will check if user specified device already
> > has a writable mountpoint. And it will stat all the mountpoints of the system. If there
> > is a dead mountpoint, this checking will be blocked and xfs_repair will enter 'D' state.
So why is the mount point dead?
That kinda means that the filesystem is still mounted, but something
has hung somewhere and the filesystem may still have active
references to the underlying device and be doing stuff that is
modifying the filesystem....
And if the device is still busy, then you aren't going to be able to
mount the repaired device, anyway, because the block device is still
busy...
> That sounds like a bug worth fixing, but I am much
> less excited about adding options which could do serious damage
> to a filesystem.
TO me it sounds like something that should be fixed by a reboot, not
by adding dangerous options to xfs_repair...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2018-02-24 22:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-24 11:23 xfs_repair: add '-F' option to ignore writable mount checking Yang Joseph
2018-02-24 17:56 ` Eric Sandeen
2018-02-24 22:04 ` Dave Chinner [this message]
2018-02-24 22:08 ` Eric Sandeen
2018-02-26 2:59 ` Yang Joseph
2018-02-26 12:02 ` Carlos Maiolino
2018-02-26 12:19 ` Brian Foster
2018-02-27 10:44 ` Yang Joseph
2018-02-27 10:57 ` Carlos Maiolino
2018-02-27 14:47 ` Eric Sandeen
2018-02-28 3:31 ` Yang Joseph
2018-02-28 3:34 ` Yang Joseph
[not found] <5A97638A.9050509@xtaotech.com>
2018-03-01 2:31 ` Yang Joseph
2018-03-02 6:23 ` Yang Joseph
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180224220428.GB30854@dastard \
--to=david@fromorbit.com \
--cc=joseph.yang@xtaotech.com \
--cc=linux-xfs@vger.kernel.org \
--cc=nathans@debian.org \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).