From: Theodore Ts'o <tytso@mit.edu>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>,
Eric Sandeen <sandeen@sandeen.net>,
Dave Chinner <david@fromorbit.com>,
Christoph Hellwig <hch@infradead.org>, Jan Kara <jack@suse.cz>,
NeilBrown <neilb@suse.com>, Jeff Mahoney <jeffm@suse.com>,
linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [RFC] mkfs config file bikeshed now!
Date: Mon, 26 Feb 2018 22:45:45 -0500 [thread overview]
Message-ID: <20180227034545.GC24294@thunk.org> (raw)
In-Reply-To: <20180227031757.GB24294@thunk.org>
One other thing I'll mention is that it was really important to me
that it was very easy to look up values from the config file. So for
me it was a lot more than just the parser. So I can fetch a read a
config parameter from the config file like this:
profile_get_boolean(ctx->profile, "options", "no_optimize_extents",
0, 0, &c);
That's because I use this for a lot more than just file system tuning
parametres, but also for changing how e2fsck / mke2fs behaves. So
trying to parse all of the config file at startup time and having to
stash that in some global context structure is just lot of extra work
that isn't necessary with the profile library compared with other
libraries which are focused exclusively on the parsing aspect of
things (which is actually pretty trivial).
Maybe this doesn't matter for XFS, but other file system utilities may
find this issue to be something worthy of consideration when trying to
pick a config file library.
- Ted
next prev parent reply other threads:[~2018-02-27 3:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 22:42 [RFC] mkfs config file bikeshed now! Darrick J. Wong
2018-02-26 23:42 ` Eric Sandeen
2018-02-26 23:56 ` Darrick J. Wong
2018-02-27 0:01 ` Eric Sandeen
2018-02-27 0:24 ` Eric Sandeen
2018-02-26 23:43 ` Eric Sandeen
2018-02-27 0:01 ` Luis R. Rodriguez
2018-02-27 0:10 ` Eric Sandeen
2018-02-27 0:15 ` Luis R. Rodriguez
2018-02-27 0:25 ` Darrick J. Wong
2018-02-27 3:17 ` Theodore Ts'o
2018-02-27 3:45 ` Theodore Ts'o [this message]
2018-02-27 13:43 ` Jan Tulak
2018-02-27 22:14 ` Dave Chinner
2018-02-27 18:11 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180227034545.GC24294@thunk.org \
--to=tytso@mit.edu \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=jeffm@suse.com \
--cc=linux-xfs@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=neilb@suse.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).