From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@sandeen.net>,
"Luis R. Rodriguez" <mcgrof@kernel.org>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs_scrub: make interpreter explicit to python3
Date: Fri, 2 Mar 2018 08:24:55 -0800 [thread overview]
Message-ID: <20180302162455.GK12763@magnolia> (raw)
In-Reply-To: <20180302090842.yln3r2qalmsvbw4j@odin.usersys.redhat.com>
On Fri, Mar 02, 2018 at 10:08:42AM +0100, Carlos Maiolino wrote:
> On Thu, Mar 01, 2018 at 10:05:09PM -0600, Eric Sandeen wrote:
> >
> >
> > On 2/23/18 10:40 PM, Darrick J. Wong wrote:
> > > On Fri, Feb 23, 2018 at 06:15:12PM -0800, Luis R. Rodriguez wrote:
> > >> Using #!/usr/bin/env makes some package dependency tools
> > >> such as rpm complain given that it cannot verify package
> > >> dependencies. Making it explicit resolves this lint rant.
> > >>
> > >> Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
> > >
> > > Looks ok,
> > > Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > intereting, my rpmbuild actually converts this on the fly. ;)
> > But fine by me to hardcode it if Darrick says ok. :)
> >
>
> Just a question though about this.
>
> What if somebody/somedistro installs python3 on another $PATH?
>
> It's been a while since I don't do any packaging stuff, so, I just wonder if
> this couldn't cause issues on distros using different install paths?
They can always patch in the path to their python3 executable.
Though, given the number of /usr/bin/python3 scripts floating around in
Google, I'm guessing a distro would have to have a really good reason to
put it elsewhere.
--D
> Cheers.
>
> > Thanks,
> > -Eric
> >
> > > --D
> > >
> > >> ---
> > >> scrub/xfs_scrub_all.in | 2 +-
> > >> 1 file changed, 1 insertion(+), 1 deletion(-)
> > >>
> > >> diff --git a/scrub/xfs_scrub_all.in b/scrub/xfs_scrub_all.in
> > >> index fff05da3ea7a..80f07d5c8b02 100644
> > >> --- a/scrub/xfs_scrub_all.in
> > >> +++ b/scrub/xfs_scrub_all.in
> > >> @@ -1,4 +1,4 @@
> > >> -#!/usr/bin/env python3
> > >> +#!/usr/bin/python3
> > >>
> > >> # Run online scrubbers in parallel, but avoid thrashing.
> > >> #
> > >> --
> > >> 2.16.2
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --
> Carlos
prev parent reply other threads:[~2018-03-02 16:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-24 2:15 [PATCH] xfs_scrub: make interpreter explicit to python3 Luis R. Rodriguez
2018-02-24 4:40 ` Darrick J. Wong
2018-03-02 4:05 ` Eric Sandeen
2018-03-02 9:08 ` Carlos Maiolino
2018-03-02 16:24 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180302162455.GK12763@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).