Re: [PATCH 3/5] libxfs: move xfs_inode_zone to rdwr.c

["Darrick J. Wong" <darrick.wong@oracle.com>]

On Tue, Mar 06, 2018 at 03:55:54PM -0600, Eric Sandeen wrote:
> The zone itself is created in rdwr.c, so define it there as
> well, and add it to the list of externs in manage_zones along
> with all the rest, for consistency.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>  libxfs/init.c | 3 +--
>  libxfs/rdwr.c | 2 +-
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/libxfs/init.c b/libxfs/init.c
> index c7d73b6..3456cb5 100644
> --- a/libxfs/init.c
> +++ b/libxfs/init.c
> @@ -45,8 +45,6 @@ int	use_xfs_buf_lock;	/* global flag: use xfs_buf_t locks for MT */
>  
>  static void manage_zones(int);	/* setup global zones */
>  
> -kmem_zone_t	*xfs_inode_zone;
> -
>  /*
>   * dev_map - map open devices to fd.
>   */
> @@ -379,6 +377,7 @@ manage_zones(int release)
>  {
>  	extern kmem_zone_t	*xfs_buf_zone;
>  	extern kmem_zone_t	*xfs_ili_zone;
> +	extern kmem_zone_t	*xfs_inode_zone;
>  	extern kmem_zone_t	*xfs_ifork_zone;
>  	extern kmem_zone_t	*xfs_buf_item_zone;
>  	extern kmem_zone_t	*xfs_da_state_zone;
> diff --git a/libxfs/rdwr.c b/libxfs/rdwr.c
> index 81701b7..3142094 100644
> --- a/libxfs/rdwr.c
> +++ b/libxfs/rdwr.c
> @@ -1351,8 +1351,8 @@ struct cache_operations libxfs_bcache_operations = {
>   * Inode cache stubs.
>   */
>  
> +kmem_zone_t		*xfs_inode_zone;

struct kmem_zone?

Otherwise,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D


>  extern kmem_zone_t	*xfs_ili_zone;
> -extern kmem_zone_t	*xfs_inode_zone;
>  
>  /*
>   * If there are inline format data / attr forks attached to this inode,
> -- 
> 1.8.3.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html