From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/2] xfs: fix double ijoin in xfs_reflink_cancel_cow_range
Date: Wed, 7 Mar 2018 05:17:25 -0800 [thread overview]
Message-ID: <20180307131725.GA32572@infradead.org> (raw)
In-Reply-To: <20180307091020.6186-3-david@fromorbit.com>
On Wed, Mar 07, 2018 at 08:10:20PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> AN inode is joined to teh same transaction twice in
> xfs_reflink_cancel_cow_range() resulting in the following assert
> failure:
Needs some major spelling love :)
>
> [ 30.180485] XFS: Assertion failed: !(lip->li_flags & XFS_LI_TRANS), file: fs/xfs/xfs_trans.c, line: 740
That assertations seems like something that only exists locally in your
tree. Any chance to send it out with this series?
The other option would be to make xfs_trans_ijoin a no-op if the inode
is already joined, except that this wouldn't work with the magic unlock
on commit. Which is a feature I find horribly confusing, so we should
get rid of it, for which we'd need to get rid of the concept of
synchronous transactions in favour of leaving the log force to the
caller, which again would be more logical.
Guess I need to look into doing these cleanups as I don't want to force
them on anyone else. Just need to finish all the other more important
bits on the todo list first :)
next prev parent reply other threads:[~2018-03-07 13:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 9:10 [PATCH 0/2] xfs: fix transaction joining problems Dave Chinner
2018-03-07 9:10 ` [PATCH 1/2] xfs: fix double ijoin in xfs_inactive_symlink_rmt() Dave Chinner
2018-03-09 18:34 ` Darrick J. Wong
2018-03-07 9:10 ` [PATCH 2/2] xfs: fix double ijoin in xfs_reflink_cancel_cow_range Dave Chinner
2018-03-07 13:17 ` Christoph Hellwig [this message]
2018-03-07 21:07 ` Dave Chinner
2018-03-08 8:17 ` Christoph Hellwig
2018-03-09 18:43 ` Darrick J. Wong
2018-03-10 0:48 ` Dave Chinner
2018-03-07 9:19 ` [PATCH 3/2] xfs: fix double ijoin in xfs_reflink_clear_inode_flag() Dave Chinner
2018-03-09 18:39 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180307131725.GA32572@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).