linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Eric Sandeen <sandeen@redhat.com>, linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH 4/5 V2] libxfs: Catch non-empty zones on destroy
Date: Thu, 8 Mar 2018 00:13:08 -0800	[thread overview]
Message-ID: <20180308081308.GF15163@infradead.org> (raw)
In-Reply-To: <7fe7fc2a-8ed6-80d7-0727-0093b19f3164@sandeen.net>

> @@ -388,16 +388,20 @@ manage_zones(int release)
>  	extern void		xfs_dir_startup();
>  
>  	if (release) {	/* free zone allocation */

I really hate this style..

But not your fault, so:

Reviewed-by: Christoph Hellwig <hch@lst.de>

  parent reply	other threads:[~2018-03-08  8:13 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-06 21:52 [PATCH 0/5] xfsprogs: my very own patchbomb Eric Sandeen
2018-03-06 21:54 ` [PATCH 1/5] libxfs: Replace XFS_BUF_SET_PTR with xfs_buf_associate_memory Eric Sandeen
2018-03-06 22:57   ` Darrick J. Wong
2018-03-08  8:09   ` Christoph Hellwig
2018-03-06 21:54 ` [PATCH 2/5] libxfs: add function to free all buffers in bcache Eric Sandeen
2018-03-06 23:11   ` Darrick J. Wong
2018-03-08  8:11   ` Christoph Hellwig
2018-03-06 21:55 ` [PATCH 3/5] libxfs: move xfs_inode_zone to rdwr.c Eric Sandeen
2018-03-06 23:01   ` Darrick J. Wong
2018-03-08  8:12   ` Christoph Hellwig
2018-03-06 21:56 ` [PATCH 4/5] libxfs: Catch non-empty zones on destroy Eric Sandeen
2018-03-06 23:06   ` Darrick J. Wong
2018-03-06 23:25     ` Eric Sandeen
2018-03-06 23:37   ` [PATCH 4/5 V2] " Eric Sandeen
2018-03-06 23:39     ` Darrick J. Wong
2018-03-08  8:13     ` Christoph Hellwig [this message]
2018-03-06 21:56 ` [PATCH 5/5] Call libxfs_destroy from other utilities Eric Sandeen
2018-03-06 23:06   ` Darrick J. Wong
2018-03-08  8:13   ` Christoph Hellwig
2018-03-06 23:24 ` [PATCH 6/5] libxfs-apply: add Signed-off-by: Eric Sandeen
2018-03-06 23:32   ` Darrick J. Wong
2018-03-06 23:36     ` Eric Sandeen
2018-03-06 23:44       ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180308081308.GF15163@infradead.org \
    --to=hch@infradead.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=sandeen@redhat.com \
    --cc=sandeen@sandeen.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).