From: Dave Chinner <david@fromorbit.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Eryu Guan <eguan@redhat.com>,
linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH v2] xfs: preserve i_rdev when recycling a reclaimable inode
Date: Wed, 14 Mar 2018 08:50:28 +1100 [thread overview]
Message-ID: <20180313215028.GE18129@dastard> (raw)
In-Reply-To: <CAOQ4uxiDHSC19-fRdZmXM5BJB3-p9_LdPgSmxpjGrdCzhV2W2Q@mail.gmail.com>
On Tue, Mar 13, 2018 at 04:33:15PM +0200, Amir Goldstein wrote:
> On Tue, Mar 13, 2018 at 3:11 PM, Christoph Hellwig <hch@lst.de> wrote:
> > On Tue, Mar 13, 2018 at 02:46:09PM +0200, Amir Goldstein wrote:
> >> OK, found the patches the fix soft lockups in generic/269 and
> >> assertion in generic/232, so expunging those 2 tests from v4.15.y
> >> test runs.
> >
> > Which patches are those? We should probably backport them to 4.15-stable.
>
> Probably, but I guess Darrick has those in his TODO.
>
> There is this series that refers to failure in generic/232:
> https://marc.info/?l=linux-xfs&m=151701545720824&w=2
>
> These 2 commits refer to generic/269 specifically in commit message:
> 70c57dcd606f xfs: skip CoW writes past EOF when writeback races with truncate
> be78ff0e7277 xfs: recheck reflink / dirty page status before freeing
> CoW reservations
> and the thread on the second commit also mentions generic/270
> (I found out the hard way that it also soft locks).
>
> But there are surely more patches for stable in master.
> I recon CC: stable and/or Fixes: tags could have been helpful,
> but I don't see any of those in v4.16-rcX from the core xfs developers.
AS I always say: if you want to maintain a stable backport kernel
with all the fixes that go into the bleeding edge, you're more than
welcome to do it.
Everyone else is flat out just keeping up with on going development
and fixing bugs in the kernel as it's moving forward. So if you have
the need for stable backports, please keep backporting patches you
need, testing them and asking the stable maintainers to include
them.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2018-03-13 21:50 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-26 7:44 [PATCH v2] xfs: preserve i_rdev when recycling a reclaimable inode Amir Goldstein
2018-01-26 7:44 ` Christoph Hellwig
2018-01-26 21:44 ` Darrick J. Wong
2018-01-29 11:07 ` Amir Goldstein
2018-01-29 15:50 ` Darrick J. Wong
2018-02-01 0:27 ` Amir Goldstein
2018-02-01 0:29 ` Amir Goldstein
2018-02-01 0:35 ` Darrick J. Wong
2018-03-11 16:08 ` Amir Goldstein
2018-03-11 16:24 ` Greg KH
2018-03-12 16:27 ` Darrick J. Wong
2018-03-12 20:16 ` Amir Goldstein
2018-03-13 6:48 ` Amir Goldstein
2018-03-13 12:46 ` Amir Goldstein
2018-03-13 13:11 ` Christoph Hellwig
2018-03-13 14:33 ` Amir Goldstein
2018-03-13 21:50 ` Dave Chinner [this message]
2018-03-14 6:24 ` Amir Goldstein
2018-03-14 12:33 ` Dave Chinner
2018-03-14 12:49 ` Christoph Hellwig
2018-03-14 15:45 ` Amir Goldstein
2018-03-14 15:46 ` Christoph Hellwig
2018-03-14 16:01 ` Darrick J. Wong
2018-03-19 13:40 ` Greg KH
2018-03-19 14:59 ` Amir Goldstein
2018-03-19 15:19 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180313215028.GE18129@dastard \
--to=david@fromorbit.com \
--cc=amir73il@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=eguan@redhat.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).