linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Carlos Maiolino <cmaiolino@redhat.com>
To: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 0/4] Remove a few macros
Date: Wed, 14 Mar 2018 14:05:26 +0100	[thread overview]
Message-ID: <20180314130526.hg2gdafncrnn3puc@odin.usersys.redhat.com> (raw)
In-Reply-To: <20180306130053.13958-1-cmaiolino@redhat.com>

Hi,

On Tue, Mar 06, 2018 at 02:00:49PM +0100, Carlos Maiolino wrote:
> For a while, these macros have been removed from kernel, removing them from
> xfsprogs brings the code closer to kernel code, and is a first step on such
> process.
> 
> I tried to get rid of such macros as more segmented as possible (1 macro per
> patch), although, last to patches are good candidates to be merged together, but
> I believe it's just cleaner to have them as separated patches
> 
> Carlos Maiolino (4):
>   Get rid of XFS_BUF_PTR() macro
>   Get rid of XFS_BUF_TARGET() macro
>   get rid of XFS_BUF_COUNT() macro
>   Get rid of XFS_BUF_SET_COUNT() macro
> 

Any updates, if I should rebase this patchset over Eric's patches and resend it,
or if I should rework something else?

I've sent a V2 changing the casts according to Dave's suggestions, and hch
preferred this version, due how GCC handles pointers calculation.

Is there anything else I should change, or can I just rebase it against Eric's
patches and resend this version?

Cheers

> -- 
> 2.14.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Carlos

      parent reply	other threads:[~2018-03-14 13:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-06 13:00 [PATCH 0/4] Remove a few macros Carlos Maiolino
2018-03-06 13:00 ` [PATCH 1/4] Get rid of XFS_BUF_PTR() macro Carlos Maiolino
2018-03-06 22:22   ` Dave Chinner
2018-03-07  6:12     ` Carlos Maiolino
2018-03-08  8:15     ` Christoph Hellwig
2018-03-06 13:00 ` [PATCH 2/4] Get rid of XFS_BUF_TARGET() macro Carlos Maiolino
2018-03-08  8:15   ` Christoph Hellwig
2018-03-06 13:00 ` [PATCH 3/4] get rid of XFS_BUF_COUNT() macro Carlos Maiolino
2018-03-08  8:15   ` Christoph Hellwig
2018-03-06 13:00 ` [PATCH 4/4] Get rid of XFS_BUF_SET_COUNT() macro Carlos Maiolino
2018-03-08  8:16   ` Christoph Hellwig
2018-03-08 13:23     ` Carlos Maiolino
2018-03-14 13:05 ` Carlos Maiolino [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180314130526.hg2gdafncrnn3puc@odin.usersys.redhat.com \
    --to=cmaiolino@redhat.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).