From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ipmail06.adl6.internode.on.net ([150.101.137.145]:9874 "EHLO ipmail06.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751381AbeCNVYo (ORCPT ); Wed, 14 Mar 2018 17:24:44 -0400 Date: Thu, 15 Mar 2018 08:24:41 +1100 From: Dave Chinner Subject: Re: XFS crash consistency bug : Loss of fsynced metadata operation Message-ID: <20180314212441.GC7000@dastard> References: <20180313042126.GB18129@dastard> <20180313224522.GZ7000@dastard> <20180314131659.wnmt5zxfhrfsld7n@rh_laptop> <20180314133258.GB7000@dastard> <20180314135752.5a2vmjr7cuavusiw@rh_laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180314135752.5a2vmjr7cuavusiw@rh_laptop> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Lukas Czerner Cc: Jayashree Mohan , linux-xfs@vger.kernel.org, Vijaychidambaram Velayudhan Pillai , Ashlie Martinez , fstests@vger.kernel.org, Theodore Ts'o On Wed, Mar 14, 2018 at 02:57:52PM +0100, Lukas Czerner wrote: > On Thu, Mar 15, 2018 at 12:32:58AM +1100, Dave Chinner wrote: > > On Wed, Mar 14, 2018 at 02:16:59PM +0100, Lukas Czerner wrote: > > > just FYI the 042 xfstest does fail on xfs with what I think is stale > > > data exposure. It might not be related at all to what crashmonkey is > > > reporting but there is something wrong nevertheless. > > > > generic/042 is unreliable and certain operations result in a > > non-zero length file because of metadata commits/writeback that > > occur as a result of the fallocate operations. It got removed from > > the auto group because it isn't a reliable test about 3 years ago: > > Sure, I just that it clearly exposes stale data on xfs. That is, the > resulting file contains data that was previously written to the > underlying image file to catch the exposure. I am aware of the non-zero > length file problem, that's not what I am pointing out though. What setup are you testing on? I haven't seen it fail in some time. Here, on emulated pmem: SECTION -- xfs FSTYP -- xfs (debug) PLATFORM -- Linux/x86_64 test4 4.16.0-rc5-dgc MKFS_OPTIONS -- -f -m rmapbt=1,reflink=1 -i sparse=1 /dev/pmem1 MOUNT_OPTIONS -- /dev/pmem1 /mnt/scratch xfs/042 10s ... 14s Passed all 1 tests SECTION -- xfs ========================= Passed all 1 tests And on a different machine, with iSCSI devices and a slightly older kernel: SECTION -- xfs FSTYP -- xfs (debug) PLATFORM -- Linux/x86_64 test2 4.16.0-rc2-dgc MKFS_OPTIONS -- -f -m rmapbt=1,reflink=1 -i sparse=1 /dev/sdg MOUNT_OPTIONS -- -o context=system_u:object_r:root_t:s0 /dev/sdg /mnt/scratch xfs/042 14s ... 14s Passed all 1 tests SECTION -- xfs ========================= Passed all 1 tests It passes just fine. Cheers, Dave. -- Dave Chinner david@fromorbit.com