From: Brian Foster <bfoster@redhat.com>
To: Dave Chiluk <chiluk+linuxxfs@indeed.com>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs: detect agfl count corruption and reset agfl
Date: Thu, 15 Mar 2018 06:38:39 -0400 [thread overview]
Message-ID: <20180315103839.GA44732@bfoster.bfoster> (raw)
In-Reply-To: <CAC=E7cUme5-0z9GjVOynD==nK5aG2athrHmm=WKA8HBFWX-hRQ@mail.gmail.com>
On Wed, Mar 14, 2018 at 03:42:50PM -0500, Dave Chiluk wrote:
> On Wed, Mar 14, 2018 at 1:12 PM, Darrick J. Wong
> <darrick.wong@oracle.com> wrote:
> > On Wed, Mar 14, 2018 at 01:17:24PM -0400, Brian Foster wrote:
...
>
> Reviewed-by Dave Chiluk <chiluk+linuxxfs@indeed.com>
>
> I'm also assuming this will get submitted back to the linux-stable
> trees as the agfl packing change is already causing issues in the
> stable trees. If you do not intend to push it into the linux-stable
> trees let me know and I'll take care of at least the major ones.
>
Yeah, I can cc stable in the next post along with the other minor fixes.
My question is how far back should this fix go? Was the plan to only go
back to v4.5 because that is where the packing fix first went in? Or
should this go back further because it looks like the packing fix was
backported to v3.10:
$ git show 96f859d52bcb1
commit 96f859d52bcb1c6ea6f3388d39862bf7143e2f30
Author: Darrick J. Wong <darrick.wong@oracle.com>
Date: Mon Jan 4 16:13:21 2016 +1100
libxfs: pack the agfl header structure so XFS_AGFL_SIZE is correct
...
cc: <stable@vger.kernel.org> # 3.10 - 4.4
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
Brian
> Thanks,
> Dave
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-03-15 10:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 17:17 [PATCH] xfs: detect agfl count corruption and reset agfl Brian Foster
2018-03-14 18:12 ` Darrick J. Wong
2018-03-14 20:42 ` Dave Chiluk
2018-03-15 10:38 ` Brian Foster [this message]
2018-03-15 15:46 ` Darrick J. Wong
2018-03-15 16:27 ` Dave Chiluk
2018-03-15 22:48 ` Dave Chinner
2018-03-15 22:26 ` Dave Chinner
2018-03-16 11:59 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180315103839.GA44732@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=chiluk+linuxxfs@indeed.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).