From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-xfs-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:46732 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751532AbeCOKil (ORCPT <rfc822;linux-xfs@vger.kernel.org>);
        Thu, 15 Mar 2018 06:38:41 -0400
Date: Thu, 15 Mar 2018 06:38:39 -0400
From: Brian Foster <bfoster@redhat.com>
Subject: Re: [PATCH] xfs: detect agfl count corruption and reset agfl
Message-ID: <20180315103839.GA44732@bfoster.bfoster>
References: <20180314171724.41951-1-bfoster@redhat.com>
 <20180314181218.GR4865@magnolia>
 <CAC=E7cUme5-0z9GjVOynD==nK5aG2athrHmm=WKA8HBFWX-hRQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAC=E7cUme5-0z9GjVOynD==nK5aG2athrHmm=WKA8HBFWX-hRQ@mail.gmail.com>
Sender: linux-xfs-owner@vger.kernel.org
List-ID: <linux-xfs.vger.kernel.org>
List-Id: xfs
To: Dave Chiluk <chiluk+linuxxfs@indeed.com>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>, linux-xfs@vger.kernel.org

On Wed, Mar 14, 2018 at 03:42:50PM -0500, Dave Chiluk wrote:
> On Wed, Mar 14, 2018 at 1:12 PM, Darrick J. Wong
> <darrick.wong@oracle.com> wrote:
> > On Wed, Mar 14, 2018 at 01:17:24PM -0400, Brian Foster wrote:
...
> 
> Reviewed-by Dave Chiluk <chiluk+linuxxfs@indeed.com>
> 
> I'm also assuming this will get submitted back to the linux-stable
> trees as the agfl packing change is already causing issues in the
> stable trees.  If you do not intend to push it into the linux-stable
> trees let me know and I'll take care of at least the major ones.
> 

Yeah, I can cc stable in the next post along with the other minor fixes.
My question is how far back should this fix go? Was the plan to only go
back to v4.5 because that is where the packing fix first went in? Or
should this go back further because it looks like the packing fix was
backported to v3.10:

$ git show 96f859d52bcb1
commit 96f859d52bcb1c6ea6f3388d39862bf7143e2f30
Author: Darrick J. Wong <darrick.wong@oracle.com>
Date:   Mon Jan 4 16:13:21 2016 +1100

    libxfs: pack the agfl header structure so XFS_AGFL_SIZE is correct
    
    ...
    
    cc: <stable@vger.kernel.org> # 3.10 - 4.4
    Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
    Reviewed-by: Dave Chinner <dchinner@redhat.com>
    Signed-off-by: Dave Chinner <david@fromorbit.com>

Brian

> Thanks,
> Dave
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html