From: Brian Foster <bfoster@redhat.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Eric Sandeen <sandeen@redhat.com>, linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH 1/2] xfs: always check for and process unlinked inodes on mount
Date: Thu, 15 Mar 2018 08:41:43 -0400 [thread overview]
Message-ID: <20180315124143.GB45325@bfoster.bfoster> (raw)
In-Reply-To: <60f1a77c-61f7-08fc-dffd-4734b1efd322@sandeen.net>
On Thu, Mar 15, 2018 at 08:19:40AM -0400, Eric Sandeen wrote:
>
>
> On 3/15/18 8:17 AM, Brian Foster wrote:
> > Have we considered anything like conditionally dirtying the log on
> > freeze only when there are open+unlinked files? It seems like that may
> > be uncommon enough to address the problem for snapshot users
> > (particularly the read-only use case mentioned in the cover letter), but
> > that's just a guess.
> >
> > Brian
>
>
> I did consider that, and was weighing the advantages with the disadvantages,
> namely unpredictable behavior for snapshots... I'm not sure how uncommon
> the situation really is.
>
Ok.
> Regarding the mount delay, Darrick suggested that maybe we need to get
> all these scans into one place if possible, for efficiency.
>
These buffers should be cached after the first scan, right? As Dave
mentioned on one of the previous threads, I think the I/O load is more
of a factor than anything else.
I'd rather see us try to eliminate these kinds of scans rather than
condense them into some kind of infrastructure that tries to
self-justify their existence. But as previously mentioned, I think it's
reasonable to add this one for now and optimize it away separately.
Brian
> -Eric
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-03-15 12:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 23:31 [PATCH 0/2] xfs: don't require a dirty log on snapshots Eric Sandeen
2018-03-07 23:32 ` [PATCH 1/2] xfs: always check for and process unlinked inodes on mount Eric Sandeen
2018-03-08 0:41 ` Eric Sandeen
2018-03-15 12:17 ` Brian Foster
2018-03-15 12:19 ` Eric Sandeen
2018-03-15 12:41 ` Brian Foster [this message]
2018-03-07 23:33 ` [PATCH 2/2] xfs: don't dirty snapshot logs for unlinked inode recovery Eric Sandeen
2018-03-24 16:20 ` Darrick J. Wong
2018-03-26 12:46 ` Brian Foster
2018-03-27 21:17 ` Dave Chinner
2021-02-23 13:42 ` Gao Xiang
2021-02-23 14:40 ` Eric Sandeen
2021-02-23 15:03 ` Gao Xiang
2021-02-23 15:46 ` Eric Sandeen
2021-02-23 15:58 ` Gao Xiang
2021-02-23 16:25 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180315124143.GB45325@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).