Re: [PATCH] xfs: detect agfl count corruption and reset agfl

[Dave Chinner <david@fromorbit.com>]

On Thu, Mar 15, 2018 at 06:38:39AM -0400, Brian Foster wrote:
> On Wed, Mar 14, 2018 at 03:42:50PM -0500, Dave Chiluk wrote:
> > On Wed, Mar 14, 2018 at 1:12 PM, Darrick J. Wong
> > <darrick.wong@oracle.com> wrote:
> > > On Wed, Mar 14, 2018 at 01:17:24PM -0400, Brian Foster wrote:
> ...
> > 
> > Reviewed-by Dave Chiluk <chiluk+linuxxfs@indeed.com>
> > 
> > I'm also assuming this will get submitted back to the linux-stable
> > trees as the agfl packing change is already causing issues in the
> > stable trees.  If you do not intend to push it into the linux-stable
> > trees let me know and I'll take care of at least the major ones.
> > 
> 
> Yeah, I can cc stable in the next post along with the other minor fixes.
> My question is how far back should this fix go? Was the plan to only go
> back to v4.5 because that is where the packing fix first went in? Or
> should this go back further because it looks like the packing fix was
> backported to v3.10:
> 
> $ git show 96f859d52bcb1
> commit 96f859d52bcb1c6ea6f3388d39862bf7143e2f30
> Author: Darrick J. Wong <darrick.wong@oracle.com>
> Date:   Mon Jan 4 16:13:21 2016 +1100
> 
>     libxfs: pack the agfl header structure so XFS_AGFL_SIZE is correct
>     
>     ...
>     
>     cc: <stable@vger.kernel.org> # 3.10 - 4.4
>     Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
>     Reviewed-by: Dave Chinner <dchinner@redhat.com>
>     Signed-off-by: Dave Chinner <david@fromorbit.com>

3.10 was when the problem was first introduced. I have no idea
whether it got backported that far but the stable kernel
maintainers, so you'll have to manually audit all current long-term
stable kernels to determine what kernels need backports.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com