From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Baruch Siach <baruch@tkos.co.il>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/2] xfs_scrub: add missing paths header
Date: Thu, 15 Mar 2018 22:25:19 -0700 [thread overview]
Message-ID: <20180316052519.GA1757@magnolia> (raw)
In-Reply-To: <27747dcbfbde8a767b1a873716fce1d3aaf17c2f.1521177696.git.baruch@tkos.co.il>
On Fri, Mar 16, 2018 at 07:21:36AM +0200, Baruch Siach wrote:
> Fix the following build failure with musl libc:
>
> xfs_scrub.c: In function ‘main’:
> xfs_scrub.c:670:11: error: ‘_PATH_MOUNTED’ undeclared (first use in this function)
> mtab = _PATH_MOUNTED;
> ^~~~~~~~~~~~~
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> scrub/xfs_scrub.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scrub/xfs_scrub.c b/scrub/xfs_scrub.c
> index ab26e6335948..eedbe34ec7b3 100644
> --- a/scrub/xfs_scrub.c
> +++ b/scrub/xfs_scrub.c
> @@ -21,6 +21,7 @@
> #include <pthread.h>
> #include <stdbool.h>
> #include <stdlib.h>
> +#include <paths.h>
> #include <sys/time.h>
> #include <sys/resource.h>
> #include <sys/statvfs.h>
> --
> 2.16.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-03-16 5:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 5:21 [PATCH 1/2] workqueue: add missing pthreads header Baruch Siach
2018-03-16 5:21 ` [PATCH 2/2] xfs_scrub: add missing paths header Baruch Siach
2018-03-16 5:25 ` Darrick J. Wong [this message]
2018-03-16 5:30 ` [PATCH 1/2] workqueue: add missing pthreads header Darrick J. Wong
2018-03-16 6:08 ` Baruch Siach
2018-03-22 22:05 ` Eric Sandeen
2018-03-22 22:58 ` Eric Sandeen
2018-03-22 23:04 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180316052519.GA1757@magnolia \
--to=darrick.wong@oracle.com \
--cc=baruch@tkos.co.il \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).