Re: [PATCH 1/2] workqueue: add missing pthreads header

["Darrick J. Wong" <darrick.wong@oracle.com>]

On Fri, Mar 16, 2018 at 07:21:35AM +0200, Baruch Siach wrote:
> Fix the following build failure with musl libc:
> 
> In file included from read_verify.c:25:0:
> ../include/workqueue.h:39:2: error: unknown type name 'pthread_t'
>   pthread_t  *threads;
>   ^~~~~~~~~
> ../include/workqueue.h:42:2: error: unknown type name 'pthread_mutex_t'
>   pthread_mutex_t  lock;
>   ^~~~~~~~~~~~~~~
> ../include/workqueue.h:43:2: error: unknown type name 'pthread_cond_t'
>   pthread_cond_t  wakeup;
>   ^~~~~~~~~~~~~~
> 
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  include/workqueue.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/workqueue.h b/include/workqueue.h
> index b4b3541701df..edb2f8ac5991 100644
> --- a/include/workqueue.h
> +++ b/include/workqueue.h
> @@ -22,6 +22,8 @@
>  #ifndef	_WORKQUEUE_H_
>  #define	_WORKQUEUE_H_
>  
> +#include <pthread.h>

Ooops, sorry about that.

Our convention within xfsprogs sources (I think) is for most header
files to avoid having headers include other headers.  Would you mind
adding this include to read_verify.c instead?

(That said, you probably ought to wait for the maintainer (Eric) to
weigh in on this before you do any more work.)

--D

> +
>  struct workqueue;
>  
>  typedef void workqueue_func_t(struct workqueue *wq, uint32_t index, void *arg);
> -- 
> 2.16.2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html