From: Eryu Guan <guaneryu@gmail.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Brian Foster <bfoster@redhat.com>,
linux-xfs@vger.kernel.org, david@fromorbit.com,
fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH] xfs: test agfl reset on bad list wrapping
Date: Tue, 20 Mar 2018 08:53:46 +0800 [thread overview]
Message-ID: <20180320005346.GS30836@localhost.localdomain> (raw)
In-Reply-To: <20180320000842.GC4866@magnolia>
On Mon, Mar 19, 2018 at 05:08:42PM -0700, Darrick J. Wong wrote:
> > > +# get standard environment, filters and checks
> > > +. ./common/rc
> > > +. ./common/xfs
> > > +. ./common/filter
> > > +. ./common/populate
> > > +
> >
> > Do we need the xfs and populate includes?
>
> common/populate has the helpers for getting/setting metadata object fields.
>
> common/xfs has _require_scratch_xfs_crc
Just a quick chime in, common/xfs is sourced automatically in common/rc
when $FSTYP is xfs, you don't need to source it in test.
Thanks,
Eryu
next prev parent reply other threads:[~2018-03-20 0:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 16:26 [PATCH] xfs: test agfl reset on bad list wrapping Darrick J. Wong
2018-03-19 17:34 ` Brian Foster
2018-03-20 0:08 ` Darrick J. Wong
2018-03-20 0:53 ` Eryu Guan [this message]
2018-03-20 10:38 ` Brian Foster
2018-03-20 16:52 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180320005346.GS30836@localhost.localdomain \
--to=guaneryu@gmail.com \
--cc=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).