From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Baruch Siach <baruch@tkos.co.il>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs_scrub: fix cross compile with libunistring
Date: Tue, 20 Mar 2018 14:34:21 -0700 [thread overview]
Message-ID: <20180320213421.GJ1757@magnolia> (raw)
In-Reply-To: <45d9ba0f01cceb75f72d157a9e4d9aaeb753a9c4.1521548516.git.baruch@tkos.co.il>
On Tue, Mar 20, 2018 at 02:21:56PM +0200, Baruch Siach wrote:
> Commit 4bbed4ecc2a (xfs_scrub: warn about normalized Unicode name collisions)
> added -lunistring to the list of the xfs_scrub dependencies. When cross
> compiling make fails to find the library on the target sysroot:
>
> make[3]: *** No rule to make target `-lunistring', needed by `xfs_scrub'. Stop.
>
> Remove -lunistring from make dependencies of xfs_scrub to fix that.
>
> Cc: Darrick J. Wong <darrick.wong@oracle.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> scrub/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scrub/Makefile b/scrub/Makefile
> index 949f6fd8ba94..979603f524ff 100644
> --- a/scrub/Makefile
> +++ b/scrub/Makefile
> @@ -69,7 +69,7 @@ vfs.c \
> xfs_scrub.c
>
> LLDLIBS += $(LIBHANDLE) $(LIBFROG) $(LIBPTHREAD) $(LIBUNISTRING) $(LIBRT)
> -LTDEPENDENCIES += $(LIBHANDLE) $(LIBFROG) $(LIBUNISTRING) $(LIBRT)
> +LTDEPENDENCIES += $(LIBHANDLE) $(LIBFROG) $(LIBRT)
I think we can drop the $LIBRT here too... but it's sort of moot since I
was about to send a big series of xfs_scrub rewrites, one of which fixed
this problem indirectly (by ripping out libunistring and replacing it
with libicu).
Thanks for catching this and the musl bugs, though. :)
--D
> LLDFLAGS = -static-libtool-libs
>
> ifeq ($(HAVE_MALLINFO),yes)
> --
> 2.16.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2018-03-20 21:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 12:21 [PATCH] xfs_scrub: fix cross compile with libunistring Baruch Siach
2018-03-20 21:34 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180320213421.GJ1757@magnolia \
--to=darrick.wong@oracle.com \
--cc=baruch@tkos.co.il \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).