From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:59971 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752189AbeCVOeW (ORCPT ); Thu, 22 Mar 2018 10:34:22 -0400 Date: Thu, 22 Mar 2018 10:34:20 -0400 From: Brian Foster Subject: Re: [PATCH v2 8/9] xfs: record inode buf errors as a xref error in inode scrubber Message-ID: <20180322143419.GE16617@bfoster.bfoster> References: <152107377037.19571.8618901963505842632.stgit@magnolia> <152107382051.19571.2865600595521884732.stgit@magnolia> <20180322062410.GU4818@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180322062410.GU4818@magnolia> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org On Wed, Mar 21, 2018 at 11:24:10PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > During the inode btree scrubs we try to confirm the freemask bits > against the inode records. If the inode buffer read fails, this is a > cross-referencing error, not a corruption of the inode btree itself. > Use the xref_process_error call here. Found via core.version middlebit > fuzz in xfs/415. > > The userspace xfs_scrub program will try to repair outright corruptions > in the agi/inobt prior to phase 3 so that the inode scan will proceed. > If only a cross-referencing error is noted, the repair program defers > the repair attempt until it can check the other space metadata at least > once. > > It is therefore essential that the inobt scrubber can correctly > distinguish between corruptions and "unable to cross-reference something > else with this inobt". > > Signed-off-by: Darrick J. Wong > --- > v2: clarify why we're doing this in the commit message > --- Thanks! Reviewed-by: Brian Foster > fs/xfs/scrub/ialloc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/xfs/scrub/ialloc.c b/fs/xfs/scrub/ialloc.c > index 63ab3f9..32e0d1a 100644 > --- a/fs/xfs/scrub/ialloc.c > +++ b/fs/xfs/scrub/ialloc.c > @@ -259,7 +259,8 @@ xfs_scrub_iallocbt_check_freemask( > > error = xfs_imap_to_bp(mp, bs->cur->bc_tp, &imap, > &dip, &bp, 0, 0); > - if (!xfs_scrub_btree_process_error(bs->sc, bs->cur, 0, &error)) > + if (!xfs_scrub_btree_xref_process_error(bs->sc, bs->cur, 0, > + &error)) > continue; > > /* Which inodes are free? */ > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html