From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Baruch Siach <baruch@tkos.co.il>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] workqueue: add missing pthreads header
Date: Thu, 22 Mar 2018 16:04:33 -0700 [thread overview]
Message-ID: <20180322230433.GE4818@magnolia> (raw)
In-Reply-To: <ab844cf6-6a77-1703-4a9b-8411bfd6acfa@sandeen.net>
On Thu, Mar 22, 2018 at 05:58:29PM -0500, Eric Sandeen wrote:
> On 3/22/18 5:05 PM, Eric Sandeen wrote:
> > On 3/16/18 1:08 AM, Baruch Siach wrote:
>
> ...
>
> >>> Our convention within xfsprogs sources (I think) is for most header
> >>> files to avoid having headers include other headers. Would you mind
> >>> adding this include to read_verify.c instead?
> >>
> >> I don't mind. But requiring every user of workqueue.h to remember to have
> >> pthread.h before, is error prone IMO.
> >>
> >>> (That said, you probably ought to wait for the maintainer (Eric) to
> >>> weigh in on this before you do any more work.)
> >
> > Sorry for the late reply.
> >
> > Eh, I think I'm inclined to just take this as-is, I don't see a downside to it.
>
> Actually now I'm on the fence, half of scrub already includes pthread.h directly :/
>
> How many C files would need to include pthread.h to get the build going?
AFAICT vfs.c read_verify.c phase[65432].c fscounters.c need to include
it directly? Though some might get away with it because they include
one of the other header files that ... eh why don't we just apply this
patch and move on? Nuts to this convention. :)
--D
> And, um, how can we get ourselves out of this "break musl, rinse, repeat" cycle?
>
> -Eric
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2018-03-22 23:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 5:21 [PATCH 1/2] workqueue: add missing pthreads header Baruch Siach
2018-03-16 5:21 ` [PATCH 2/2] xfs_scrub: add missing paths header Baruch Siach
2018-03-16 5:25 ` Darrick J. Wong
2018-03-16 5:30 ` [PATCH 1/2] workqueue: add missing pthreads header Darrick J. Wong
2018-03-16 6:08 ` Baruch Siach
2018-03-22 22:05 ` Eric Sandeen
2018-03-22 22:58 ` Eric Sandeen
2018-03-22 23:04 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180322230433.GE4818@magnolia \
--to=darrick.wong@oracle.com \
--cc=baruch@tkos.co.il \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).