linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH][next] xfs: fix zero'ing of ILOG owner bits by using correct bitwise operator
@ 2018-03-27 14:40 Colin King
  0 siblings, 0 replies; only message in thread
From: Colin King @ 2018-03-27 14:40 UTC (permalink / raw)
  To: Darrick J . Wong, linux-xfs; +Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

Currently the masking of the ili_fields is using the ! operator which
results in masking with 0, which clears all the bits which is not
intended.  Instead, use the ~ operator that negates the inverts the
bits to correctly mask out the XFS_ILOG_AOWNER and XFS_ILOG_DOWNER
bits.

Detected by CoverityScan, CID#1466877 ("Logical vs bitwise operator")

Fixes: 3fdf96830762 ("xfs: do not log swapext extent owner changes for deleted")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 fs/xfs/xfs_inode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
index a16f48fde4da..3e3aab3888fa 100644
--- a/fs/xfs/xfs_inode.c
+++ b/fs/xfs/xfs_inode.c
@@ -2477,7 +2477,7 @@ xfs_ifree(
 	ip->i_d.di_aformat = XFS_DINODE_FMT_EXTENTS;
 
 	/* Don't attempt to replay owner changes for a deleted inode */
-	ip->i_itemp->ili_fields &= !(XFS_ILOG_AOWNER|XFS_ILOG_DOWNER);
+	ip->i_itemp->ili_fields &= ~(XFS_ILOG_AOWNER|XFS_ILOG_DOWNER);
 
 	/*
 	 * Bump the generation count so no one will be confused
-- 
2.15.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2018-03-27 14:40 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-27 14:40 [PATCH][next] xfs: fix zero'ing of ILOG owner bits by using correct bitwise operator Colin King

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).