From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 07/20] xfs: create tracepoints for online repair
Date: Tue, 27 Mar 2018 16:33:55 -0700 [thread overview]
Message-ID: <20180327233355.GJ4818@magnolia> (raw)
In-Reply-To: <20180327231844.GY18129@dastard>
On Wed, Mar 28, 2018 at 10:18:44AM +1100, Dave Chinner wrote:
> On Mon, Mar 26, 2018 at 04:56:39PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > These tracepoints will be used to debug the online repair routines.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
>
> Cant really say anything about the tracepoint contents themselves
> at this point. One minor nit:
>
> ....
> > + TP_printk("dev %d:%d agno %u agbno %u len %u refcount %u",
> > + MAJOR(__entry->dev), MINOR(__entry->dev),
> > + __entry->agno,
> > + __entry->startblock,
> > + __entry->blockcount,
> > + __entry->refcount)
>
> This is the normal TP_printk parameter stacking format, but....
>
> > +)
> > +
> > +TRACE_EVENT(xfs_repair_init_btblock,
> > + TP_PROTO(struct xfs_mount *mp, xfs_agnumber_t agno, xfs_agblock_t agbno,
> > + xfs_btnum_t btnum),
> > + TP_ARGS(mp, agno, agbno, btnum),
> > + TP_STRUCT__entry(
> > + __field(dev_t, dev)
> > + __field(xfs_agnumber_t, agno)
> > + __field(xfs_agblock_t, agbno)
> > + __field(uint32_t, btnum)
> > + ),
> > + TP_fast_assign(
> > + __entry->dev = mp->m_super->s_dev;
> > + __entry->agno = agno;
> > + __entry->agbno = agbno;
> > + __entry->btnum = btnum;
> > + ),
> > + TP_printk("dev %d:%d agno %u agbno %u btnum %d",
> > + MAJOR(__entry->dev), MINOR(__entry->dev), __entry->agno,
> > + __entry->agbno, __entry->btnum)
>
> from here on you pack mulitple parameters to a line, which is
> different to everything else in the tracepoint code. Can you unpack
> them?
Ok.
> Otherwise:
>
> Reviewed-by: Dave Chinner <dchinner@redhat.com>
>
> /me is wondering if we're getting to the point where we need to
> split up xfs_trace.h?
Probably, but this is fs/xfs/scrub/trace.h which is only 500 lines so
far. :)
--D
> Cheers,
>
> Dave.
> --
> Dave Chinner
> david@fromorbit.com
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-03-27 23:34 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 23:55 [PATCH v14 00/20] xfs-4.17: online repair support Darrick J. Wong
2018-03-26 23:56 ` [PATCH 01/20] xfs: add helpers to calculate btree size Darrick J. Wong
2018-03-27 22:54 ` Dave Chinner
2018-03-26 23:56 ` [PATCH 02/20] xfs: expose various functions to repair code Darrick J. Wong
2018-03-27 22:55 ` Dave Chinner
2018-03-26 23:56 ` [PATCH 03/20] xfs: add repair helpers for the reverse mapping btree Darrick J. Wong
2018-03-27 23:03 ` Dave Chinner
2018-03-27 23:29 ` Darrick J. Wong
2018-03-26 23:56 ` [PATCH 04/20] xfs: add repair helpers for the reference count btree Darrick J. Wong
2018-03-27 23:04 ` Dave Chinner
2018-03-26 23:56 ` [PATCH 05/20] xfs: add BMAPI_NORMAP flag to perform block remapping without updating rmpabt Darrick J. Wong
2018-03-27 23:09 ` Dave Chinner
2018-03-26 23:56 ` [PATCH 06/20] xfs: halt auto-reclamation activities while rebuilding rmap Darrick J. Wong
2018-03-27 23:15 ` Dave Chinner
2018-03-27 23:50 ` Darrick J. Wong
2018-03-26 23:56 ` [PATCH 07/20] xfs: create tracepoints for online repair Darrick J. Wong
2018-03-27 23:18 ` Dave Chinner
2018-03-27 23:33 ` Darrick J. Wong [this message]
2018-03-26 23:56 ` [PATCH 08/20] xfs: implement the metadata repair ioctl flag Darrick J. Wong
2018-03-27 23:55 ` Dave Chinner
2018-03-28 4:58 ` Darrick J. Wong
2018-03-28 23:19 ` Darrick J. Wong
2018-03-28 23:42 ` Dave Chinner
2018-03-26 23:56 ` [PATCH 09/20] xfs: add helper routines for the repair code Darrick J. Wong
2018-03-26 23:56 ` [PATCH 10/20] xfs: repair superblocks Darrick J. Wong
2018-03-26 23:57 ` [PATCH 11/20] xfs: repair the AGF and AGFL Darrick J. Wong
2018-03-26 23:57 ` [PATCH 12/20] xfs: repair the AGI Darrick J. Wong
2018-03-26 23:57 ` [PATCH 13/20] xfs: repair free space btrees Darrick J. Wong
2018-03-26 23:57 ` [PATCH 14/20] xfs: repair inode btrees Darrick J. Wong
2018-03-26 23:57 ` [PATCH 15/20] xfs: repair the rmapbt Darrick J. Wong
2018-03-26 23:57 ` [PATCH 16/20] xfs: repair refcount btrees Darrick J. Wong
2018-03-26 23:57 ` [PATCH 17/20] xfs: repair inode records Darrick J. Wong
2018-03-26 23:57 ` [PATCH 18/20] xfs: zap broken inode forks Darrick J. Wong
2018-03-26 23:57 ` [PATCH 19/20] xfs: repair inode block maps Darrick J. Wong
2018-03-26 23:58 ` [PATCH 20/20] xfs: repair damaged symlinks Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2018-03-15 20:26 [PATCH v13 00/20] xfs-4.17: online repair support Darrick J. Wong
2018-03-15 20:27 ` [PATCH 07/20] xfs: create tracepoints for online repair Darrick J. Wong
2018-02-23 2:01 [PATCH v12 00/20] xfs: online repair support Darrick J. Wong
2018-02-23 2:02 ` [PATCH 07/20] xfs: create tracepoints for online repair Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180327233355.GJ4818@magnolia \
--to=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).