From: Sasha Levin <Alexander.Levin@microsoft.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Sasha Levin <levinsasha928@gmail.com>,
"Luis R. Rodriguez" <mcgrof@kernel.org>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Christoph Hellwig <hch@lst.de>, xfs <linux-xfs@vger.kernel.org>,
"linux-kernel@vger.kernel.org List"
<linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Julia Lawall <julia.lawall@lip6.fr>,
Josh Triplett <josh@joshtriplett.org>,
Takashi Iwai <tiwai@suse.de>, Michal Hocko <mhocko@kernel.org>,
Joerg Roedel <joro@8bytes.org>
Subject: Re: [PATCH] xfs: always free inline data before resetting inode fork during ifree
Date: Wed, 28 Mar 2018 19:30:06 +0000 [thread overview]
Message-ID: <20180328193004.GB7561@sasha-vm> (raw)
In-Reply-To: <20180328033228.GA18129@dastard>
On Wed, Mar 28, 2018 at 02:32:28PM +1100, Dave Chinner wrote:
>How much time are your test rigs going to be able to spend running
>xfstests? A single pass on a single filesysetm config on spinning
>disks will take 3-4 hours of run time. And we have at least 4 common
>configs that need validation (v4, v4 w/ 512b block size, v5
>(defaults), and v5 w/ reflink+rmap) and so you're looking at a
>minimum 12-24 hours of machine test time per kernel you'd need to
>test.
No reason they can't run in parallel, right?
>> > From: Sasha Levin <alexander.levin@microsoft.com>
>> > To: Sasha Levin <alexander.levin@microsoft.com>
>> > To: linux-xfs@vger.kernel.org, "Darrick J . Wong" <darrick.wong@oracle.com>
>> > Cc: Brian Foster <bfoster@redhat.com>, linux-kernel@vger.kernel.org
>> > Subject: Re: [PATCH] xfs: Correctly invert xfs_buftarg LRU isolation logic
>> > In-Reply-To: <20180306102638.25322-1-vbendel@redhat.com>
>> > References: <20180306102638.25322-1-vbendel@redhat.com>
>> >
>> > Hi Vratislav Bendel,
>> >
>> > [This is an automated email]
>> >
>> > This commit has been processed by the -stable helper bot and determined
>> > to be a high probability candidate for -stable trees. (score: 6.4845)
>> >
>> > The bot has tested the following trees: v4.15.12, v4.14.29, v4.9.89, v4.4.123, v4.1.50, v3.18.101.
>> >
>> > v4.15.12: OK!
>> > v4.14.29: OK!
>> > v4.9.89: OK!
>> > v4.4.123: OK!
>> > v4.1.50: OK!
>> > v3.18.101: OK!
>> >
>> > Please reply with "ack" to have this patch included in the appropriate stable trees.
>
>That might help, but the testing and validation is completely
>opaque. If I wanted to know what that "OK!" actually meant, where
>do I go to find that out?
This is actually something I want maintainers to dictate. What sort of
testing would make the XFS folks happy here? Right now I'm doing
"./check 'xfs/*'" with xfstests. Is it sufficient? Anything else you'd like to see?
--
Thanks,
Sasha
next prev parent reply other threads:[~2018-03-28 19:30 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 6:01 [PATCH] xfs: always free inline data before resetting inode fork during ifree Darrick J. Wong
2017-11-23 8:14 ` Christoph Hellwig
2018-03-23 1:30 ` Luis R. Rodriguez
2018-03-23 3:41 ` Darrick J. Wong
2018-03-23 17:08 ` Luis R. Rodriguez
2018-03-23 17:26 ` Darrick J. Wong
2018-03-23 18:23 ` Luis R. Rodriguez
2018-03-24 9:06 ` Greg Kroah-Hartman
2018-03-24 17:21 ` Darrick J. Wong
2018-03-26 4:54 ` Sasha Levin
2018-03-26 6:48 ` Darrick J. Wong
2018-03-26 17:39 ` Luis R. Rodriguez
2018-03-25 22:33 ` Dave Chinner
2018-03-26 23:54 ` Sasha Levin
2018-03-27 7:06 ` Michal Hocko
2018-03-27 19:54 ` Luis R. Rodriguez
2018-03-28 13:21 ` Michal Hocko
2018-03-28 19:33 ` Sasha Levin
2018-03-29 7:01 ` Michal Hocko
2018-03-28 1:11 ` Sasha Levin
2018-03-28 13:20 ` Michal Hocko
2018-03-28 3:32 ` Dave Chinner
2018-03-28 19:30 ` Sasha Levin [this message]
2018-03-28 19:40 ` Darrick J. Wong
2018-03-28 23:05 ` Dave Chinner
2018-03-29 18:12 ` Luis R. Rodriguez
2018-03-29 18:17 ` Josef Bacik
2018-03-29 18:36 ` Sasha Levin
2018-03-30 2:47 ` Sasha Levin
2018-03-30 19:49 ` Luis R. Rodriguez
2018-04-02 0:35 ` Sasha Levin
2018-03-31 22:02 ` Dave Chinner
2018-04-02 0:32 ` Sasha Levin
2018-04-03 1:46 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180328193004.GB7561@sasha-vm \
--to=alexander.levin@microsoft.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=joro@8bytes.org \
--cc=josh@joshtriplett.org \
--cc=julia.lawall@lip6.fr \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mhocko@kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).