From: Dave Chinner <david@fromorbit.com>
To: "cgxu519@gmx.com" <cgxu519@gmx.com>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
Christoph Hellwig <hch@infradead.org>,
linux-xfs@vger.kernel.org, Brian Foster <bfoster@redhat.com>,
Eric Sandeen <sandeen@sandeen.net>
Subject: Re: [PATCH] xfs: use hardlimit as sub-fs size if both hard/soft limits are set
Date: Fri, 6 Apr 2018 07:44:04 +1000 [thread overview]
Message-ID: <20180405214404.GF23861@dastard> (raw)
In-Reply-To: <66BA750A-5A49-4B81-BC99-40DC89216856@gmx.com>
On Thu, Apr 05, 2018 at 09:40:03AM +0800, cgxu519@gmx.com wrote:
> Hi Dave, Christoph
>
> Any objection for this?
Silence generally means "I don't really care".
Rule of thumb: if it's user visible and likely to be used in
scripts, then we have to be really careful about changing behaviour
as it can break user scripts. This ticks both boxes, so I'd be
wanting more justification than "I noticed this" as a reason for
changing it.
Darrick seems to be covering that concern just fine :)
-Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2018-04-05 21:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-25 5:16 [PATCH] xfs: use hardlimit as sub-fs size if both hard/soft limits are set Chengguang Xu
2018-03-26 19:22 ` Darrick J. Wong
2018-03-26 19:43 ` Darrick J. Wong
2018-03-27 0:14 ` cgxu519
2018-04-05 1:40 ` cgxu519
2018-04-05 21:44 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180405214404.GF23861@dastard \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=cgxu519@gmx.com \
--cc=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).