From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
Eric Sandeen <sandeen@redhat.com>,
linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH 2/6] xfs: pass xfs_dqblk to xfs_dquot_verify/xfs_dquot_repair
Date: Fri, 6 Apr 2018 08:40:33 +1000 [thread overview]
Message-ID: <20180405224033.GG23861@dastard> (raw)
In-Reply-To: <5c02fc77-28b6-4665-82f3-699fda82688c@sandeen.net>
On Wed, Apr 04, 2018 at 11:13:03PM -0500, Eric Sandeen wrote:
> On 4/4/18 10:52 PM, Darrick J. Wong wrote:
> > On Wed, Apr 04, 2018 at 01:54:26PM -0500, Eric Sandeen wrote:
> >> In order to validate the UUID in xfs_dquot_verify, we need
> >> the full xfs_qblk, not just the xfs_disk_dquot_t (which is
> >
> > ^^^^^^^^^ xfs_dqblk, right?
>
> yup
>
> ...
>
> >> @@ -192,14 +191,10 @@
> >
> > Any way you can get your diff generator to add -p to spit out the
> > alleged function this chunk is supposed to land in? It makes reviewing
> > patches somewhat easier for me. :)
>
> No doubt ... I don't know why it doesn't do so, sorry. :/ Will try
> to figure that out. Sorry about that.
diff -up
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2018-04-05 22:40 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 18:47 [PATCH 0/6] xfs: quota fixes and enhancements Eric Sandeen
2018-04-04 18:49 ` [PATCH 1/6] xfs: remove unused flags arg from xfs_dquot_verify Eric Sandeen
2018-04-05 7:11 ` Christoph Hellwig
2018-05-01 16:13 ` Darrick J. Wong
2018-04-04 18:54 ` [PATCH 2/6] xfs: pass xfs_dqblk to xfs_dquot_verify/xfs_dquot_repair Eric Sandeen
2018-04-05 3:52 ` Darrick J. Wong
2018-04-05 4:13 ` Eric Sandeen
2018-04-05 22:40 ` Dave Chinner [this message]
2018-04-06 2:50 ` Eric Sandeen
2018-04-06 3:30 ` Dave Chinner
2018-04-11 3:28 ` Darrick J. Wong
2018-04-05 7:14 ` Christoph Hellwig
2018-05-01 16:25 ` Darrick J. Wong
2018-05-01 18:58 ` [PATCH 2/6 V2] " Eric Sandeen
2018-04-04 19:00 ` [PATCH 3/6] xfs: validate UUID and type in xfs_dquot_verify Eric Sandeen
2018-04-05 7:14 ` Christoph Hellwig
2018-05-01 16:13 ` Darrick J. Wong
2018-05-02 16:20 ` Darrick J. Wong
2018-04-04 19:06 ` [PATCH 4/6] xfs: quieter quota initialization with bad dquots Eric Sandeen
2018-04-05 7:14 ` Christoph Hellwig
2018-05-01 16:23 ` Darrick J. Wong
2018-04-04 19:10 ` [PATCH 5/6] xfs: factor out quota time limit initialization Eric Sandeen
2018-04-05 7:15 ` Christoph Hellwig
2018-04-05 12:36 ` Eric Sandeen
2018-04-05 22:49 ` Dave Chinner
2018-05-01 16:23 ` Darrick J. Wong
2018-05-01 19:00 ` [PATCH 5/6 V2] " Eric Sandeen
2018-04-04 19:12 ` [PATCH 6/6] xfs: delay quota timelimit init until after quotacheck Eric Sandeen
2018-04-05 7:16 ` Christoph Hellwig
2018-05-01 16:24 ` Darrick J. Wong
2018-04-07 22:00 ` [PATCH 0/6] xfs: quota fixes and enhancements Eric Sandeen
2018-04-08 1:37 ` Darrick J. Wong
2018-04-08 1:48 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180405224033.GG23861@dastard \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox