From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp2130.oracle.com ([141.146.126.79]:47304 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751570AbeDFQbF (ORCPT ); Fri, 6 Apr 2018 12:31:05 -0400 Date: Fri, 6 Apr 2018 09:31:01 -0700 From: "Darrick J. Wong" Subject: Re: [PATCH 03/21] xfs: add repair helpers for the reverse mapping btree Message-ID: <20180406163101.GI7500@magnolia> References: <152269897182.16346.1710955088267364781.stgit@magnolia> <152269899099.16346.10130327272084087800.stgit@magnolia> <20180405230218.GI23861@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180405230218.GI23861@dastard> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Dave Chinner Cc: linux-xfs@vger.kernel.org On Fri, Apr 06, 2018 at 09:02:18AM +1000, Dave Chinner wrote: > On Mon, Apr 02, 2018 at 12:56:31PM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong > > > > Add a couple of functions to the reverse mapping btree that will be used > > to repair the rmapbt. > > > > Signed-off-by: Darrick J. Wong > > Minor nit: > > > +struct xfs_rmap_key_state { > > + uint64_t owner; > > + uint64_t offset; > > + unsigned int flags; > > + bool has_rmap; > > +}; > > + > > +/* For each rmap given, figure out if it doesn't match the key we want. */ > > +STATIC int > > +xfs_rmap_has_other_keys_helper( > > + struct xfs_btree_cur *cur, > > + struct xfs_rmap_irec *rec, > > + void *priv) > > +{ > > + struct xfs_rmap_key_state *rhok = priv; > > rks rather than rhok? Yep yep, fixed. --D > > Otherwise looks ok. > > Reviewed-by: Dave Chinner > > -- > Dave Chinner > david@fromorbit.com > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html