From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH 0/6] xfs: quota fixes and enhancements
Date: Sat, 7 Apr 2018 18:37:57 -0700 [thread overview]
Message-ID: <20180408013757.GN7500@magnolia> (raw)
In-Reply-To: <6479893d-7f01-f262-6ec5-84a33237d2d8@sandeen.net>
On Sat, Apr 07, 2018 at 05:00:13PM -0500, Eric Sandeen wrote:
> On 4/4/18 1:47 PM, Eric Sandeen wrote:
> > A semi-random smattering of quota stuff. First three seem quite
> > good to go, the rest are more along the lines of a suggestion
> > or conversation-starter. ;)
> >
> > (the first patch is just removing an unused arg).
> >
> > xfs_repair doesn't look at quota blocks. At all. It relies
> > on quotacheck in the kernel to fix them up as needed.
>
> I'm starting to rethink a lot of this hackery. Why doesn't xfs_repair
> just fix things up? (leave quotacheck to the next mount, but the
> "repair" stuff in the kernel seems like a really strange wart.)
>
> I think I'll look at teaching repair to sanity check the quota
> inodes, but if anyone knows why that's a bad idea please let me
> know. ;)
/me shrugs, we still need to fix the kernel's quota verifiers to check
the uuid and all that, right? Which means that both are going to need
patches, afaict.
--D
> Thanks,
> -Eric
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-04-08 1:38 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 18:47 [PATCH 0/6] xfs: quota fixes and enhancements Eric Sandeen
2018-04-04 18:49 ` [PATCH 1/6] xfs: remove unused flags arg from xfs_dquot_verify Eric Sandeen
2018-04-05 7:11 ` Christoph Hellwig
2018-05-01 16:13 ` Darrick J. Wong
2018-04-04 18:54 ` [PATCH 2/6] xfs: pass xfs_dqblk to xfs_dquot_verify/xfs_dquot_repair Eric Sandeen
2018-04-05 3:52 ` Darrick J. Wong
2018-04-05 4:13 ` Eric Sandeen
2018-04-05 22:40 ` Dave Chinner
2018-04-06 2:50 ` Eric Sandeen
2018-04-06 3:30 ` Dave Chinner
2018-04-11 3:28 ` Darrick J. Wong
2018-04-05 7:14 ` Christoph Hellwig
2018-05-01 16:25 ` Darrick J. Wong
2018-05-01 18:58 ` [PATCH 2/6 V2] " Eric Sandeen
2018-04-04 19:00 ` [PATCH 3/6] xfs: validate UUID and type in xfs_dquot_verify Eric Sandeen
2018-04-05 7:14 ` Christoph Hellwig
2018-05-01 16:13 ` Darrick J. Wong
2018-05-02 16:20 ` Darrick J. Wong
2018-04-04 19:06 ` [PATCH 4/6] xfs: quieter quota initialization with bad dquots Eric Sandeen
2018-04-05 7:14 ` Christoph Hellwig
2018-05-01 16:23 ` Darrick J. Wong
2018-04-04 19:10 ` [PATCH 5/6] xfs: factor out quota time limit initialization Eric Sandeen
2018-04-05 7:15 ` Christoph Hellwig
2018-04-05 12:36 ` Eric Sandeen
2018-04-05 22:49 ` Dave Chinner
2018-05-01 16:23 ` Darrick J. Wong
2018-05-01 19:00 ` [PATCH 5/6 V2] " Eric Sandeen
2018-04-04 19:12 ` [PATCH 6/6] xfs: delay quota timelimit init until after quotacheck Eric Sandeen
2018-04-05 7:16 ` Christoph Hellwig
2018-05-01 16:24 ` Darrick J. Wong
2018-04-07 22:00 ` [PATCH 0/6] xfs: quota fixes and enhancements Eric Sandeen
2018-04-08 1:37 ` Darrick J. Wong [this message]
2018-04-08 1:48 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180408013757.GN7500@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).