From: Christoph Hellwig <hch@infradead.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Dave Chinner <david@fromorbit.com>,
Souptick Joarder <jrdr.linux@gmail.com>,
darrick.wong@oracle.com, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] fs: xfs: Change return type to vm_fault_t
Date: Sun, 15 Apr 2018 00:21:21 -0700 [thread overview]
Message-ID: <20180415072121.GA13601@infradead.org> (raw)
In-Reply-To: <20180414222407.GA15294@bombadil.infradead.org>
On Sat, Apr 14, 2018 at 03:24:07PM -0700, Matthew Wilcox wrote:
> On Sun, Apr 15, 2018 at 07:59:37AM +1000, Dave Chinner wrote:
> > On Sun, Apr 15, 2018 at 01:35:30AM +0530, Souptick Joarder wrote:
> > > Use new return type vm_fault_t for fault handlers.
> > >
> > > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> > > Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>
> >
> > Ummm. Why are we adding typedefs to hide basic types?
> >
> > typedef int vm_fault_t;
>
> That's the intermediate step. It's going to become a sparse typedef
> like gfp_t once everything's converted. And the "why" is that people
> are still returning -EFOO when they should be returning VM_FAULT_FOO.
Please just send one damn patch adding the typedef and the sparse
annotation and converting everyone over. Splitting this into five
gazillion patches that do nothing doesn't help anyone.
next prev parent reply other threads:[~2018-04-15 7:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-14 20:05 [PATCH] fs: xfs: Change return type to vm_fault_t Souptick Joarder
2018-04-14 21:59 ` Dave Chinner
2018-04-14 22:24 ` Matthew Wilcox
2018-04-15 7:21 ` Christoph Hellwig [this message]
2018-04-15 11:11 ` Matthew Wilcox
2018-04-15 12:04 ` Christoph Hellwig
2018-04-15 12:34 ` Matthew Wilcox
2018-04-16 8:57 ` Christoph Hellwig
2018-04-16 11:14 ` Matthew Wilcox
2018-04-16 11:23 ` Christoph Hellwig
2018-04-16 11:31 ` Matthew Wilcox
2018-04-16 17:03 ` Darrick J. Wong
2018-05-30 12:35 ` Souptick Joarder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180415072121.GA13601@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=jrdr.linux@gmail.com \
--cc=linux-xfs@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).