From: Christoph Hellwig <hch@infradead.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Dave Chinner <david@fromorbit.com>,
Souptick Joarder <jrdr.linux@gmail.com>,
darrick.wong@oracle.com, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] fs: xfs: Change return type to vm_fault_t
Date: Mon, 16 Apr 2018 04:23:53 -0700 [thread overview]
Message-ID: <20180416112353.GA22921@infradead.org> (raw)
In-Reply-To: <20180416111423.GA26022@bombadil.infradead.org>
On Mon, Apr 16, 2018 at 04:14:23AM -0700, Matthew Wilcox wrote:
> That's an unreasonable request. It would (usually) require writing more
> code to convert errnos into VM_FAULT returns. And that code would get
> precisely zero testing upstream because the next commit would come along
> and delete it, replacing it with calls to common code.
Well, introduce the damn common code first. It does not require
using the typedef in any way.
In this current form of single patches: NAK to anything I maintain
or review.
Send out an actual series, and think about how to order it best.
next prev parent reply other threads:[~2018-04-16 11:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-14 20:05 [PATCH] fs: xfs: Change return type to vm_fault_t Souptick Joarder
2018-04-14 21:59 ` Dave Chinner
2018-04-14 22:24 ` Matthew Wilcox
2018-04-15 7:21 ` Christoph Hellwig
2018-04-15 11:11 ` Matthew Wilcox
2018-04-15 12:04 ` Christoph Hellwig
2018-04-15 12:34 ` Matthew Wilcox
2018-04-16 8:57 ` Christoph Hellwig
2018-04-16 11:14 ` Matthew Wilcox
2018-04-16 11:23 ` Christoph Hellwig [this message]
2018-04-16 11:31 ` Matthew Wilcox
2018-04-16 17:03 ` Darrick J. Wong
2018-05-30 12:35 ` Souptick Joarder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180416112353.GA22921@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=jrdr.linux@gmail.com \
--cc=linux-xfs@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).