From: Christoph Hellwig <hch@infradead.org>
To: Xiong Zhou <xzhou@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org,
fstests@vger.kernel.org, sandeen@sandeen.net,
linux-xfs@vger.kernel.org
Subject: Re: ioctl FIBMAP for dax gone in v4.17-rc1
Date: Tue, 17 Apr 2018 09:10:56 -0700 [thread overview]
Message-ID: <20180417161056.GA24257@infradead.org> (raw)
In-Reply-To: <20180417144059.nwbbynhgq3k3i63q@XZHOUW.usersys.redhat.com>
On Tue, Apr 17, 2018 at 10:40:59PM +0800, Xiong Zhou wrote:
> We got these in v4.17-rc1:
> 6e2608d xfs, dax: introduce xfs_dax_aops
> fb094c9 ext2, dax: introduce ext2_dax_aops
> 5f0663b ext4, dax: introduce ext4_dax_aops
>
> And we don't have ->bmap call in these aops, which may lead
> to the ioctl call failure.
>
> Do we have any plan of adding/supporting it ?
>
> xfstests generic/223 covers this issue. If we are not going
> to support this call for dax, we need to fix the testcase.
Not supporting ->bmap is a good thing as it is hightly dangerous.
The t_stripetest tool used by generic/223 should really be
rewritten to suppot FIEMAP.
next parent reply other threads:[~2018-04-17 16:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180417144059.nwbbynhgq3k3i63q@XZHOUW.usersys.redhat.com>
2018-04-17 16:10 ` Christoph Hellwig [this message]
2018-04-17 16:53 ` ioctl FIBMAP for dax gone in v4.17-rc1 Dan Williams
2018-04-17 16:57 ` Darrick J. Wong
2018-04-17 17:05 ` Dan Williams
2018-04-17 17:40 ` Andreas Dilger
2018-04-17 17:47 ` Dan Williams
2018-04-17 17:50 ` Darrick J. Wong
2018-04-17 23:34 ` Theodore Y. Ts'o
2018-04-17 23:36 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180417161056.GA24257@infradead.org \
--to=hch@infradead.org \
--cc=fstests@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
--cc=xzhou@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).