From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] xfs: make xfs_buf_incore out of line
Date: Wed, 18 Apr 2018 03:29:29 -0700 [thread overview]
Message-ID: <20180418102929.GB15190@infradead.org> (raw)
In-Reply-To: <20180418002111.11637-2-david@fromorbit.com>
On Wed, Apr 18, 2018 at 10:21:10AM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Move xfs_buf_incore out of line and make it the only way to look up
> a buffer in the buffer cache from outside the buffer cache. Convert
> the external users of _xfs_buf_find() to xfs_buf_incore() and make
> _xfs_buf_find() static.
>
> Signed-Off-By: Dave Chinner <dchinner@redhat.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2018-04-18 10:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 0:21 [PATCH 0/2] xfs: optimise XBF_TRYLOCK buffer lookups Dave Chinner
2018-04-18 0:21 ` [PATCH 1/2] xfs: make xfs_buf_incore out of line Dave Chinner
2018-04-18 10:29 ` Christoph Hellwig [this message]
2018-04-18 11:46 ` Carlos Maiolino
2018-04-18 15:24 ` Darrick J. Wong
2018-04-18 23:34 ` Dave Chinner
2018-04-19 1:10 ` Darrick J. Wong
2018-04-18 0:21 ` [PATCH 2/2] xfs: don't retry xfs_buf_find on XBF_TRYLOCK failure Dave Chinner
2018-04-18 10:30 ` Christoph Hellwig
2018-04-18 11:53 ` Carlos Maiolino
2018-04-18 15:24 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180418102929.GB15190@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).