From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 02/11] xfs: create the XFS_QMOPT_QUOTIP_LOCKED flag
Date: Thu, 19 Apr 2018 01:32:24 -0700 [thread overview]
Message-ID: <20180419083224.GA17515@infradead.org> (raw)
In-Reply-To: <152401917977.11465.9543981144688523511.stgit@magnolia>
On Tue, Apr 17, 2018 at 07:39:39PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Create a new QMOPT flag to signal that we've already locked the quota
> inode. This will be used by the quota scrub code refactoring to avoid
> dropping the quota ip lock during scrub. The flag is incompatible with
> the DQALLOC flag because dquot allocation creates a transaction, and we
> shouldn't be doing that with the ILOCK held.
Locked flag are always a sign for code smell. And this already is
pretty smelly code before that flag is added. I think someone (i.e.
either you or me :)) needs to do a major refactoring here first.
next prev parent reply other threads:[~2018-04-19 8:32 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 2:39 [PATCH 00/11] xfs-4.18: online scrub fixes Darrick J. Wong
2018-04-18 2:39 ` [PATCH 01/11] xfs: skip scrub xref if corruption already noted Darrick J. Wong
2018-04-18 15:03 ` Brian Foster
2018-04-18 16:02 ` Darrick J. Wong
2018-04-18 2:39 ` [PATCH 02/11] xfs: create the XFS_QMOPT_QUOTIP_LOCKED flag Darrick J. Wong
2018-04-18 15:33 ` Brian Foster
2018-04-18 16:55 ` Darrick J. Wong
2018-04-18 17:09 ` Brian Foster
2018-04-19 8:32 ` Christoph Hellwig [this message]
2018-04-21 18:42 ` Darrick J. Wong
2018-04-18 2:39 ` [PATCH 03/11] xfs: report failing address when dquot verifier fails Darrick J. Wong
2018-04-18 18:33 ` Brian Foster
2018-04-18 2:40 ` [PATCH 04/11] xfs: refactor dquot iteration Darrick J. Wong
2018-04-18 18:34 ` Brian Foster
2018-04-18 22:20 ` Darrick J. Wong
2018-04-18 2:40 ` [PATCH 05/11] xfs: avoid ilock games in the quota scrubber Darrick J. Wong
2018-04-18 18:34 ` Brian Foster
2018-04-18 2:40 ` [PATCH 06/11] xfs: quota scrub should use bmapbtd scrubber Darrick J. Wong
2018-04-18 18:34 ` Brian Foster
2018-04-18 20:00 ` Darrick J. Wong
2018-04-19 11:20 ` Brian Foster
2018-04-18 2:40 ` [PATCH 07/11] xfs: superblock scrub should use uncached buffers Darrick J. Wong
2018-04-19 12:55 ` Brian Foster
2018-04-19 17:25 ` Darrick J. Wong
2018-04-19 18:57 ` Brian Foster
2018-04-20 0:07 ` Dave Chinner
2018-04-21 0:29 ` Darrick J. Wong
2018-04-20 0:05 ` Dave Chinner
2018-04-18 2:40 ` [PATCH 08/11] xfs: clean up scrub usage of KM_NOFS Darrick J. Wong
2018-04-19 12:55 ` Brian Foster
2018-04-18 2:40 ` [PATCH 09/11] xfs: btree scrub should check minrecs Darrick J. Wong
2018-04-19 12:55 ` Brian Foster
2018-04-18 2:40 ` [PATCH 10/11] xfs: refactor scrub transaction allocation function Darrick J. Wong
2018-04-19 12:56 ` Brian Foster
2018-04-18 2:40 ` [PATCH 11/11] xfs: avoid ABBA deadlock when scrubbing parent pointers Darrick J. Wong
2018-04-19 12:56 ` Brian Foster
2018-04-19 17:33 ` Darrick J. Wong
2018-04-19 18:58 ` Brian Foster
2018-04-19 19:06 ` Darrick J. Wong
2018-04-21 0:31 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180419083224.GA17515@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).