From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: xfs <linux-xfs@vger.kernel.org>,
fstests <fstests@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH v2] xfs: cap the length of deduplication requests
Date: Sun, 22 Apr 2018 06:53:05 -0700 [thread overview]
Message-ID: <20180422135305.GB26268@magnolia> (raw)
In-Reply-To: <CAOQ4uxguonNyKB=M7mhNouOhbhar3voLjneeSZDY3xooePPnjg@mail.gmail.com>
On Sun, Apr 22, 2018 at 05:57:32AM +0300, Amir Goldstein wrote:
> On Wed, Apr 18, 2018 at 5:57 AM, Darrick J. Wong
> <darrick.wong@oracle.com> wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Since deduplication potentially has to read in all the pages in both
> > files in order to compare the contents, cap the deduplication request
> > length at MAX_RW_COUNT/2 (roughly 1GB) so that we have /some/ upper bound
> > on the request length and can't just lock up the kernel forever. Found
> > by running generic/304 after commit 1ddae54555b62a ("common/rc: add
> > missing 'local' keywords").
> >
>
> With this patch generic/304 doesn't soft lock the kernel, but it doesn't
> seem 'quick' at all. I stopped waiting after 5 minutes. Is that expected?
> If so, best get the test out of the quick group.
No, that is incorrect behavior; the test is buggy.
> Can you shed some light on how the "missing 'local' keywords" change
> exposed this behavior?
See the patch I sent to the fstests lists to fix generic/304.
--D
> Thanks,
> Amir.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-04-22 13:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 5:19 [PATCH] xfs: cap the length of deduplication requests Darrick J. Wong
2018-04-17 6:58 ` Christoph Hellwig
2018-04-17 15:44 ` Darrick J. Wong
2018-04-18 2:57 ` [PATCH v2] " Darrick J. Wong
2018-04-22 2:57 ` Amir Goldstein
2018-04-22 13:53 ` Darrick J. Wong [this message]
2018-05-02 15:30 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180422135305.GB26268@magnolia \
--to=darrick.wong@oracle.com \
--cc=amir73il@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).