From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: linux-xfs <linux-xfs@vger.kernel.org>, Jan Tulak <jtulak@redhat.com>
Subject: Re: [PATCH] fsck.xfs: do not use 'function' keyword
Date: Sun, 29 Apr 2018 22:30:59 -0700 [thread overview]
Message-ID: <20180430053059.GA21688@magnolia> (raw)
In-Reply-To: <20a302b8-a5c8-7cf2-94d4-3cc41560976c@sandeen.net>
On Sun, Apr 29, 2018 at 08:15:28PM -0500, Eric Sandeen wrote:
> It was pointed out on irc that fsck.xfs uses the 'function' keyword
> although it invokes /bin/sh - 'function' is a bashism. It's not needed
> here, so just remove it.
>
> Fixes: 04a2d5d ("fsck.xfs: allow forced repairs using xfs_repair")
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Does RHEL have 'checkbashisms'?
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
>
> This might be a 4.16.1 item, if strict-sh initscripts fail to run fsck.xfs at
> boot time ...?
>
> diff --git a/fsck/xfs_fsck.sh b/fsck/xfs_fsck.sh
> index c9fc3eb..1916c07 100755
> --- a/fsck/xfs_fsck.sh
> +++ b/fsck/xfs_fsck.sh
> @@ -6,7 +6,7 @@
> NAME=$0
>
> # get the right return code for fsck
> -function repair2fsck_code() {
> +repair2fsck_code() {
> case $1 in
> 0) return 0 # everything is ok
> ;;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-04-30 5:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 1:15 [PATCH] fsck.xfs: do not use 'function' keyword Eric Sandeen
2018-04-30 5:30 ` Darrick J. Wong [this message]
2018-04-30 13:28 ` Eric Sandeen
2018-04-30 13:43 ` Jan Tulak
2018-04-30 7:46 ` Jan Tulak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180430053059.GA21688@magnolia \
--to=darrick.wong@oracle.com \
--cc=jtulak@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox