From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH 4/5 V2] xfs: implement online get/set fs label
Date: Thu, 3 May 2018 07:57:01 +1000 [thread overview]
Message-ID: <20180502215701.GC23861@dastard> (raw)
In-Reply-To: <d364f3c8-110a-fb69-f2a5-c3b5716f556e@sandeen.net>
On Wed, May 02, 2018 at 09:28:35AM -0500, Eric Sandeen wrote:
> On 5/2/18 9:24 AM, Darrick J. Wong wrote:
> > On Tue, May 01, 2018 at 06:04:09PM -0500, Eric Sandeen wrote:
> >> The GET ioctl is trivial, just return the current label.
> >> +static int
> >> +xfs_ioc_getlabel(
> >> + struct xfs_mount *mp,
> >> + char __user *label)
> >> +{
> >> + struct xfs_sb *sbp = &mp->m_sb;
> >> +
> >> + /* Paranoia */
> >> + BUILD_BUG_ON(sizeof(sbp->sb_fname) > FSLABEL_MAX);
> >> +
> >> + if (copy_to_user(label, sbp->sb_fname, sizeof(sbp->sb_fname)))
> >
> > Needs to ensure that a null is set at the end of the (userspace) buffer
> > just in case the label is "123456789012".
>
> Oh, yup!
>
> > There's nothing in the documentation for this ioctl <cough> that says
> > the passed in buffer must already be zeroed.
>
> where /do/ we document ioctls like this, anyway?
man pages. You should really cc linux-api@vger.kernel.org on any
patch that introduces/hoists a new VFS ioctl, as well as the man
page patch to document it.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2018-05-02 21:57 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 15:40 [PATCH 0/5] xfs: add online relabel capabilities Eric Sandeen
2018-04-30 15:42 ` [PATCH 1/5] fs: hoist BTRFS_IOC_[SG]ET_FSLABEL to vfs Eric Sandeen
2018-05-02 14:30 ` Darrick J. Wong
2018-04-30 15:43 ` [PATCH 2/5] xfs: factor out secondary superblock updates Eric Sandeen
2018-05-01 14:17 ` Brian Foster
2018-05-01 14:19 ` Eric Sandeen
2018-05-02 14:29 ` Darrick J. Wong
2018-04-30 15:45 ` [PATCH 3/5] xfs: move xfs_scrub_checkpoint_log to xfs_log_checkpoint for general use Eric Sandeen
2018-05-01 23:04 ` Eric Sandeen
2018-04-30 15:46 ` [PATCH 4/5] xfs: implement online get/set fs label Eric Sandeen
2018-05-01 14:18 ` Brian Foster
2018-05-01 14:27 ` Eric Sandeen
2018-05-01 14:42 ` Brian Foster
2018-05-01 14:49 ` Darrick J. Wong
2018-05-01 15:01 ` Eric Sandeen
2018-05-01 22:11 ` Dave Chinner
2018-05-01 22:20 ` Eric Sandeen
2018-05-01 23:04 ` [PATCH 4/5 V2] " Eric Sandeen
2018-05-02 10:48 ` Brian Foster
2018-05-02 14:24 ` Darrick J. Wong
2018-05-02 14:28 ` Eric Sandeen
2018-05-02 14:38 ` Darrick J. Wong
2018-05-02 21:57 ` Dave Chinner [this message]
2018-04-30 15:48 ` [PATCH 5/5] xfs_io: add label command Eric Sandeen
2018-05-02 14:37 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180502215701.GC23861@dastard \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).