From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-xfs@vger.kernel.org,
dchinner@redhat.com, hch@lst.de
Subject: Re: [PATCH 2/3] blk-wbt: account any writing command as a write
Date: Mon, 7 May 2018 11:53:26 +0200 [thread overview]
Message-ID: <20180507095326.GB25210@lst.de> (raw)
In-Reply-To: <1525360843-6504-3-git-send-email-axboe@kernel.dk>
On Thu, May 03, 2018 at 09:20:42AM -0600, Jens Axboe wrote:
> We currently special case WRITE and FLUSH, but we should really
> just include any command with the write bit set. This ensures
> that we account DISCARD.
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
> diff --git a/block/blk-wbt.c b/block/blk-wbt.c
> index f92fc84b5e2c..3e34b41bcefc 100644
> --- a/block/blk-wbt.c
> +++ b/block/blk-wbt.c
> @@ -701,7 +701,7 @@ static int wbt_data_dir(const struct request *rq)
>
> if (op == REQ_OP_READ)
> return READ;
> - else if (op == REQ_OP_WRITE || op == REQ_OP_FLUSH)
> + else if (op_is_write(op))
> return WRITE;
>
> /* don't account */
But this whole function smells, the return value is an array
index, so instead of abusing read/write this should return 0 or 1
and be called _idx or similar. But I guess that is a question for the
higher level interface.
next prev parent reply other threads:[~2018-05-07 9:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 15:20 [PATCHSET 0/3] Add throttling for discards Jens Axboe
2018-05-03 15:20 ` [PATCH 1/3] block: break discard submissions into the user defined size Jens Axboe
2018-05-07 9:51 ` Christoph Hellwig
2018-05-07 15:47 ` Jens Axboe
2018-05-03 15:20 ` [PATCH 2/3] blk-wbt: account any writing command as a write Jens Axboe
2018-05-07 9:53 ` Christoph Hellwig [this message]
2018-05-03 15:20 ` [PATCH 3/3] blk-wbt: throttle discards like background writes Jens Axboe
2018-05-07 9:57 ` Christoph Hellwig
2018-05-07 15:51 ` Jens Axboe
2018-05-03 17:45 ` [PATCHSET 0/3] Add throttling for discards Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180507095326.GB25210@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dchinner@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).