From: Christoph Hellwig <hch@infradead.org>
To: Brian Foster <bfoster@redhat.com>
Cc: Dave Chinner <david@fromorbit.com>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 05/10] xfs: don't assert fail with AIL lock held
Date: Mon, 7 May 2018 07:50:48 -0700 [thread overview]
Message-ID: <20180507145048.GG7476@infradead.org> (raw)
In-Reply-To: <20180507121806.GF38916@bfoster.bfoster>
> Otherwise seems Ok, but kind of ugly. What about something like the
> following diff (applied on top of this patch)? Still hacky, but it
> avoids the multiple lock cycles for each check failure and preserves the
> actual assert strings. (Untested and probably could use comment
> updates..).
This looks a little better. But maybe we should just replace the
ASSERT statements with WARN_ON_ONCE calls to make them non-fatal
but otherwise leave things as-is?
next prev parent reply other threads:[~2018-05-07 14:50 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 8:01 [PATCH 0/10] xfs: log item and transaction cleanups Dave Chinner
2018-05-02 8:01 ` [PATCH 01/10] xfs: log item flags are racy Dave Chinner
2018-05-07 12:16 ` Brian Foster
2018-05-07 14:45 ` Christoph Hellwig
2018-05-02 8:01 ` [PATCH 02/10] xfs: catch log items multiply joined to a transaction Dave Chinner
2018-05-07 12:16 ` Brian Foster
2018-05-07 14:48 ` Christoph Hellwig
2018-05-08 0:06 ` Dave Chinner
2018-05-02 8:01 ` [PATCH 03/10] xfs: add tracing to high level transaction operations Dave Chinner
2018-05-07 12:17 ` Brian Foster
2018-05-07 14:48 ` Christoph Hellwig
2018-05-02 8:01 ` [PATCH 04/10] xfs: adder caller IP to xfs_defer* tracepoints Dave Chinner
2018-05-07 12:17 ` Brian Foster
2018-05-07 14:49 ` Christoph Hellwig
2018-05-02 8:01 ` [PATCH 05/10] xfs: don't assert fail with AIL lock held Dave Chinner
2018-05-07 12:18 ` Brian Foster
2018-05-07 14:50 ` Christoph Hellwig [this message]
2018-05-07 23:59 ` Dave Chinner
2018-05-02 8:01 ` [PATCH 06/10] xfs: fix double ijoin in xfs_inactive_symlink_rmt() Dave Chinner
2018-05-07 14:51 ` Christoph Hellwig
2018-05-02 8:01 ` [PATCH 07/10] xfs: fix double ijoin in xfs_reflink_cancel_cow_range Dave Chinner
2018-05-07 14:51 ` Christoph Hellwig
2018-05-02 8:01 ` [PATCH 08/10] xfs: fix double ijoin in xfs_reflink_clear_inode_flag() Dave Chinner
2018-05-07 14:52 ` Christoph Hellwig
2018-05-02 8:01 ` [PATCH 09/10] xfs: add some more debug checks to buffer log item reuse Dave Chinner
2018-05-07 14:52 ` Christoph Hellwig
2018-05-02 8:01 ` [PATCH 10/10] xfs: get rid of the log item descriptor Dave Chinner
2018-05-02 20:05 ` Darrick J. Wong
2018-05-02 21:53 ` Dave Chinner
2018-05-03 23:47 ` Darrick J. Wong
2018-05-07 14:55 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180507145048.GG7476@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).