From: hal@deer-run.com
To: Eric Sandeen <sandeen@sandeen.net>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH] xfs_db: add -R option
Date: Tue, 8 May 2018 11:43:40 -0500 [thread overview]
Message-ID: <20180508164340.GB18224@deer-run.com> (raw)
In-Reply-To: <c542d34d-3afa-c75e-32ba-9ba2df17b8d0@sandeen.net>
> Well, I don't really like either patch for the reasons stated above.
> xfs_db /can/ write to the filesystem, and -r disables that... but -r
> as a modifier to affect the behavior of a read-only command is
> unintuitive.
>
> "It is only necessary to omit this flag if a command that changes data
> (write, blocktrash, crc) is to be used."
>
> What are the objections to a blockget modifier option? That seemed like
> the most direct & obvious solution to me.
>
> "blockget/check -L : attempt to perform the blockget and check functions
> even if the log contains unreplayed metadata," or something like that?
Ah, OK. I'm getting what you're saying now. Let me poke around with
the code some and produce a patch that does what you're suggesting.
--Hal
next prev parent reply other threads:[~2018-05-08 16:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 14:02 [PATCH] xfs_db: add -R option hal
2018-05-04 15:32 ` Darrick J. Wong
2018-05-07 11:35 ` hal
2018-05-07 12:56 ` hal
2018-05-08 1:21 ` Darrick J. Wong
2018-05-08 13:55 ` Eric Sandeen
2018-05-08 16:13 ` hal
2018-05-08 16:27 ` Eric Sandeen
2018-05-08 16:43 ` hal [this message]
2018-05-08 16:58 ` Darrick J. Wong
2018-05-09 0:14 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180508164340.GB18224@deer-run.com \
--to=hal@deer-run.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).