From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org, Brian Foster <bfoster@redhat.com>, hch@lst.de
Subject: Re: [PATCH 13/14] xfs: rename on-disk dquot counter zap functions
Date: Fri, 11 May 2018 09:05:52 +0200 [thread overview]
Message-ID: <20180511070552.GA8774@lst.de> (raw)
In-Reply-To: <152596621328.27525.8570053354806323352.stgit@magnolia>
On Thu, May 10, 2018 at 08:30:13AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> The function 'xfs_qm_dqiterate' doesn't iterate dquots at all, it
> iterates all dquot blocks of a quota inode and clears the counters.
> Therefore, change the name to something more descriptive so that we can
> introduce a real dquot iterator later.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> Reviewed-by: Brian Foster <bfoster@redhat.com>
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2018-05-11 7:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 15:28 [PATCH v3 00/14] xfs-4.18: quota refactor Darrick J. Wong
2018-05-10 15:28 ` [PATCH 01/14] xfs: release new dquot buffer on defer_finish error Darrick J. Wong
2018-05-10 15:28 ` [PATCH 02/14] xfs: don't spray logs when dquot flush/purge fail Darrick J. Wong
2018-05-10 15:29 ` [PATCH 03/14] xfs: refactor XFS_QMOPT_DQNEXT out of existence Darrick J. Wong
2018-05-10 15:29 ` [PATCH 04/14] xfs: refactor dquot cache handling Darrick J. Wong
2018-05-10 15:29 ` [PATCH 05/14] xfs: delegate dqget input checks to helper function Darrick J. Wong
2018-05-10 15:29 ` [PATCH 06/14] xfs: remove unnecessary xfs_qm_dqattach parameter Darrick J. Wong
2018-05-10 15:29 ` [PATCH 07/14] xfs: split out dqget for inodes from regular dqget Darrick J. Wong
2018-05-10 15:29 ` [PATCH 08/14] xfs: fetch dquots directly during quotacheck Darrick J. Wong
2018-05-10 15:29 ` [PATCH 09/14] xfs: refactor incore dquot initialization functions Darrick J. Wong
2018-05-10 15:29 ` [PATCH 10/14] xfs: refactor xfs_qm_dqtobp and xfs_qm_dqalloc Darrick J. Wong
2018-05-10 15:30 ` [PATCH 11/14] xfs: remove direct calls to _qm_dqread Darrick J. Wong
2018-05-10 15:30 ` [PATCH 12/14] xfs: replace XFS_QMOPT_DQALLOC with a simple boolean Darrick J. Wong
2018-05-10 15:30 ` [PATCH 13/14] xfs: rename on-disk dquot counter zap functions Darrick J. Wong
2018-05-11 7:05 ` Christoph Hellwig [this message]
2018-05-10 15:30 ` [PATCH 14/14] xfs: refactor dquot iteration Darrick J. Wong
2018-05-11 7:06 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180511070552.GA8774@lst.de \
--to=hch@lst.de \
--cc=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).