From: Dave Chinner <david@fromorbit.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: fstests <fstests@vger.kernel.org>, linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs: test mount vs superblock shrinker races
Date: Sat, 12 May 2018 09:54:06 +1000 [thread overview]
Message-ID: <20180511235406.GA23861@dastard> (raw)
In-Reply-To: <CAOQ4uxh+D_1jEJquR5uyv2-AQpnNyZ9iiXFSqW6eSMmcPDi7Jw@mail.gmail.com>
On Fri, May 11, 2018 at 08:41:58AM +0300, Amir Goldstein wrote:
> On Fri, May 11, 2018 at 5:11 AM, Dave Chinner
> <david@fromorbit.com> wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > Test case for superblock shrinkers running while the filesystem
> > is being set up and/or torn down and tripping over inconsistent
> > state.
> >
> > Signed-Off-By: Dave Chinner <dchinner@redhat.com> ---
...
>
> Isn't it dangerous for the time being? Your fix commit message
> says you got reports of OOPS.
If you have a kernel with the mount_delay sysfs option, you will
have a kernel with the fix. If you don't have mount_delay, the test
won't run.
> Not sure what should be the authoritative condition to remove dangerous
> point kernel release with a fix??
I'm not going to add "dangerous" to new regression tests that have a
fix pending anymore because nobody is doing maintenance tasks like
sweeping out tests that aren't dangerous to upstream. Tagging new
regression tests as dangerous just creates unnecessary technical
debt.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2018-05-11 23:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 2:11 [PATCH] xfs: test mount vs superblock shrinker races Dave Chinner
2018-05-11 5:41 ` Amir Goldstein
2018-05-11 23:54 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180511235406.GA23861@dastard \
--to=david@fromorbit.com \
--cc=amir73il@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox