* [PATCH] xfs: fix refactor quota limits initialization
@ 2018-05-16 1:01 Darrick J. Wong
2018-05-16 1:08 ` Dave Chinner
0 siblings, 1 reply; 2+ messages in thread
From: Darrick J. Wong @ 2018-05-16 1:01 UTC (permalink / raw)
To: linux-xfs, Dave Chinner; +Cc: bfoster
dquot warning fields are be16, not be32. Fix this mistake.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
fs/xfs/xfs_qm.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/xfs/xfs_qm.c b/fs/xfs/xfs_qm.c
index 913d46d01bfc..c3e014bfc848 100644
--- a/fs/xfs/xfs_qm.c
+++ b/fs/xfs/xfs_qm.c
@@ -636,11 +636,11 @@ xfs_qm_init_timelimits(
if (ddqp->d_rtbtimer)
qinf->qi_rtbtimelimit = be32_to_cpu(ddqp->d_rtbtimer);
if (ddqp->d_bwarns)
- qinf->qi_bwarnlimit = be32_to_cpu(ddqp->d_bwarns);
+ qinf->qi_bwarnlimit = be16_to_cpu(ddqp->d_bwarns);
if (ddqp->d_iwarns)
- qinf->qi_iwarnlimit = be32_to_cpu(ddqp->d_iwarns);
+ qinf->qi_iwarnlimit = be16_to_cpu(ddqp->d_iwarns);
if (ddqp->d_rtbwarns)
- qinf->qi_rtbwarnlimit = be32_to_cpu(ddqp->d_rtbwarns);
+ qinf->qi_rtbwarnlimit = be16_to_cpu(ddqp->d_rtbwarns);
xfs_qm_dqdestroy(dqp);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs: fix refactor quota limits initialization
2018-05-16 1:01 [PATCH] xfs: fix refactor quota limits initialization Darrick J. Wong
@ 2018-05-16 1:08 ` Dave Chinner
0 siblings, 0 replies; 2+ messages in thread
From: Dave Chinner @ 2018-05-16 1:08 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: linux-xfs, bfoster
On Tue, May 15, 2018 at 06:01:08PM -0700, Darrick J. Wong wrote:
> dquot warning fields are be16, not be32. Fix this mistake.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> fs/xfs/xfs_qm.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/xfs/xfs_qm.c b/fs/xfs/xfs_qm.c
> index 913d46d01bfc..c3e014bfc848 100644
> --- a/fs/xfs/xfs_qm.c
> +++ b/fs/xfs/xfs_qm.c
> @@ -636,11 +636,11 @@ xfs_qm_init_timelimits(
> if (ddqp->d_rtbtimer)
> qinf->qi_rtbtimelimit = be32_to_cpu(ddqp->d_rtbtimer);
> if (ddqp->d_bwarns)
> - qinf->qi_bwarnlimit = be32_to_cpu(ddqp->d_bwarns);
> + qinf->qi_bwarnlimit = be16_to_cpu(ddqp->d_bwarns);
> if (ddqp->d_iwarns)
> - qinf->qi_iwarnlimit = be32_to_cpu(ddqp->d_iwarns);
> + qinf->qi_iwarnlimit = be16_to_cpu(ddqp->d_iwarns);
> if (ddqp->d_rtbwarns)
> - qinf->qi_rtbwarnlimit = be32_to_cpu(ddqp->d_rtbwarns);
> + qinf->qi_rtbwarnlimit = be16_to_cpu(ddqp->d_rtbwarns);
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
FWIW, this points out that we need to start de-typedef-ing the quota
code as well clean it up. We've been pretty good about this in the
rest of the XFS code over the years, perhaps it's time for the quota
code to catch up?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-16 1:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-16 1:01 [PATCH] xfs: fix refactor quota limits initialization Darrick J. Wong
2018-05-16 1:08 ` Dave Chinner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).