From: Dave Chinner <david@fromorbit.com>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: sandeen@sandeen.net, linux-xfs@vger.kernel.org,
darrick.wong@oracle.com, jack@suse.com, jeffm@suse.com,
okurz@suse.com, lpechacek@suse.com, jtulak@redhat.com
Subject: Re: [PATCH v2 1/5] mkfs: distinguish between struct sb_feat_args and struct cli_params
Date: Fri, 18 May 2018 08:02:55 +1000 [thread overview]
Message-ID: <20180517220255.GB23861@dastard> (raw)
In-Reply-To: <20180517192700.23457-2-mcgrof@kernel.org>
On Thu, May 17, 2018 at 12:26:56PM -0700, Luis R. Rodriguez wrote:
> The struct sb_feat_args will actually be shared between the code which
> processes command line options and the configuration file, as such we
> need to clarify and reflect this clearly in documentation.
>
> Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
Sensible.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2018-05-17 22:03 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 19:26 [PATCH v2 0/5] xfsprogs: add mkfs.xfs configuration file parsing support Luis R. Rodriguez
2018-05-17 19:26 ` [PATCH v2 1/5] mkfs: distinguish between struct sb_feat_args and struct cli_params Luis R. Rodriguez
2018-05-17 22:02 ` Dave Chinner [this message]
2018-05-17 19:26 ` [PATCH v2 2/5] mkfs: move shared structs and cli params into their own headers Luis R. Rodriguez
2018-05-17 22:40 ` Dave Chinner
2018-05-17 23:54 ` Luis R. Rodriguez
2018-05-18 0:49 ` Dave Chinner
2018-05-19 1:33 ` Luis R. Rodriguez
2018-05-17 19:26 ` [PATCH v2 3/5] mkfs: replace defaults source with an enum Luis R. Rodriguez
2018-05-17 22:48 ` Dave Chinner
2018-05-17 23:09 ` Luis R. Rodriguez
2018-05-18 0:53 ` Dave Chinner
2018-05-17 19:26 ` [PATCH v2 4/5] mkfs: add helpers to process defaults Luis R. Rodriguez
2018-05-17 22:53 ` Dave Chinner
2018-05-18 0:06 ` Luis R. Rodriguez
2018-05-17 19:27 ` [PATCH v2 5/5] mkfs.xfs: add configuration file parsing support using our own parser Luis R. Rodriguez
2018-05-17 21:31 ` Darrick J. Wong
2018-05-18 0:29 ` Luis R. Rodriguez
2018-05-21 18:32 ` Luis R. Rodriguez
2018-05-18 0:44 ` Dave Chinner
2018-05-19 1:32 ` Luis R. Rodriguez
2018-05-21 0:14 ` Dave Chinner
2018-05-21 15:30 ` Darrick J. Wong
2018-05-21 16:58 ` Luis R. Rodriguez
2018-05-22 19:37 ` Luis R. Rodriguez
2018-05-18 3:24 ` Eric Sandeen
2018-05-18 3:46 ` Darrick J. Wong
2018-05-18 15:38 ` Luis R. Rodriguez
2018-05-18 17:09 ` Eric Sandeen
2018-05-18 23:56 ` Luis R. Rodriguez
2018-05-21 9:40 ` Jan Tulak
2018-05-25 0:50 ` Luis R. Rodriguez
2018-05-20 0:16 ` Dave Chinner
2018-05-21 15:33 ` Darrick J. Wong
2018-05-21 17:05 ` Luis R. Rodriguez
2018-05-21 22:10 ` Dave Chinner
2018-05-21 22:24 ` Eric Sandeen
2018-05-22 0:38 ` Dave Chinner
2018-05-25 0:51 ` Luis R. Rodriguez
2018-05-25 0:54 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180517220255.GB23861@dastard \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=jack@suse.com \
--cc=jeffm@suse.com \
--cc=jtulak@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=lpechacek@suse.com \
--cc=mcgrof@kernel.org \
--cc=okurz@suse.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).