linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* xfs regression
@ 2018-05-22  0:29 Dave Jiang
  2018-05-22  1:43 ` Darrick J. Wong
  0 siblings, 1 reply; 3+ messages in thread
From: Dave Jiang @ 2018-05-22  0:29 UTC (permalink / raw)
  To: Darrick J. Wong; +Cc: linux-xfs

Darrick,
I may have hit an xfs regression that shows up in 4.16 that fails
xfstest xfs/348. I have bisected it to this commit:
9cfb9b47479e237d217dbcfafe034cbf98f45909 ("xfs: provide a centralized
method for verifying inline fork data")

# ./check xfs/348
FSTYP         -- xfs (non-debug)
PLATFORM      -- Linux/x86_64 skx-ntbusd 4.15.0-rc7+
MKFS_OPTIONS  -- -f -bsize=4096 /dev/pmem0p2
MOUNT_OPTIONS -- -o context=system_u:object_r:root_t:s0 /dev/pmem0p2
/mnt/xfstests_scratch

xfs/348 29s ... - output mismatch (see
/root/xfstests/xfstests-dev/results//xfs/348.out.bad)
    --- tests/xfs/348.out       2017-10-19 10:57:22.561819578 -0700
    +++ /root/xfstests/xfstests-dev/results//xfs/348.out.bad
2018-05-21 17:13:39.171256163 -0700
    @@ -239,7 +239,7 @@
     would have junked entry "DIR" in directory PARENT_INO
     would have junked entry "EMPTY" in directory PARENT_INO
     would have junked entry "FIFO" in directory PARENT_INO
    -stat: 'SCRATCH_MNT/test/DIR' is a symbolic link
    +stat: cannot stat 'SCRATCH_MNT/test/DIR': Structure needs cleaning
     stat: 'SCRATCH_MNT/test/DATA' is a symbolic link
     stat: cannot stat 'SCRATCH_MNT/test/EMPTY': Structure needs cleaning
    ...
    (Run 'diff -u tests/xfs/348.out
/root/xfstests/xfstests-dev/results//xfs/348.out.bad'  to see the entire
diff)
Ran: xfs/348
Failures: xfs/348
Failed 1 of 1 tests

-- 

Dave Jiang
Software Engineer, SSG/OTC
Intel Corp.
dave.jiang@intel.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: xfs regression
  2018-05-22  0:29 xfs regression Dave Jiang
@ 2018-05-22  1:43 ` Darrick J. Wong
  2018-05-22 15:41   ` Dave Jiang
  0 siblings, 1 reply; 3+ messages in thread
From: Darrick J. Wong @ 2018-05-22  1:43 UTC (permalink / raw)
  To: Dave Jiang; +Cc: linux-xfs

On Mon, May 21, 2018 at 05:29:44PM -0700, Dave Jiang wrote:
> Darrick,
> I may have hit an xfs regression that shows up in 4.16 that fails
> xfstest xfs/348. I have bisected it to this commit:
> 9cfb9b47479e237d217dbcfafe034cbf98f45909 ("xfs: provide a centralized
> method for verifying inline fork data")
> 
> # ./check xfs/348
> FSTYP         -- xfs (non-debug)
> PLATFORM      -- Linux/x86_64 skx-ntbusd 4.15.0-rc7+
> MKFS_OPTIONS  -- -f -bsize=4096 /dev/pmem0p2
> MOUNT_OPTIONS -- -o context=system_u:object_r:root_t:s0 /dev/pmem0p2
> /mnt/xfstests_scratch
> 
> xfs/348 29s ... - output mismatch (see
> /root/xfstests/xfstests-dev/results//xfs/348.out.bad)
>     --- tests/xfs/348.out       2017-10-19 10:57:22.561819578 -0700
>     +++ /root/xfstests/xfstests-dev/results//xfs/348.out.bad
> 2018-05-21 17:13:39.171256163 -0700
>     @@ -239,7 +239,7 @@
>      would have junked entry "DIR" in directory PARENT_INO
>      would have junked entry "EMPTY" in directory PARENT_INO
>      would have junked entry "FIFO" in directory PARENT_INO
>     -stat: 'SCRATCH_MNT/test/DIR' is a symbolic link
>     +stat: cannot stat 'SCRATCH_MNT/test/DIR': Structure needs cleaning

That was fixed in (xfstests) commit 60ba1274f5d79b.

--D

>      stat: 'SCRATCH_MNT/test/DATA' is a symbolic link
>      stat: cannot stat 'SCRATCH_MNT/test/EMPTY': Structure needs cleaning
>     ...
>     (Run 'diff -u tests/xfs/348.out
> /root/xfstests/xfstests-dev/results//xfs/348.out.bad'  to see the entire
> diff)
> Ran: xfs/348
> Failures: xfs/348
> Failed 1 of 1 tests
> 
> -- 
> 
> Dave Jiang
> Software Engineer, SSG/OTC
> Intel Corp.
> dave.jiang@intel.com
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: xfs regression
  2018-05-22  1:43 ` Darrick J. Wong
@ 2018-05-22 15:41   ` Dave Jiang
  0 siblings, 0 replies; 3+ messages in thread
From: Dave Jiang @ 2018-05-22 15:41 UTC (permalink / raw)
  To: Darrick J. Wong; +Cc: linux-xfs



On 05/21/2018 06:43 PM, Darrick J. Wong wrote:
> On Mon, May 21, 2018 at 05:29:44PM -0700, Dave Jiang wrote:
>> Darrick,
>> I may have hit an xfs regression that shows up in 4.16 that fails
>> xfstest xfs/348. I have bisected it to this commit:
>> 9cfb9b47479e237d217dbcfafe034cbf98f45909 ("xfs: provide a centralized
>> method for verifying inline fork data")
>>
>> # ./check xfs/348
>> FSTYP         -- xfs (non-debug)
>> PLATFORM      -- Linux/x86_64 skx-ntbusd 4.15.0-rc7+
>> MKFS_OPTIONS  -- -f -bsize=4096 /dev/pmem0p2
>> MOUNT_OPTIONS -- -o context=system_u:object_r:root_t:s0 /dev/pmem0p2
>> /mnt/xfstests_scratch
>>
>> xfs/348 29s ... - output mismatch (see
>> /root/xfstests/xfstests-dev/results//xfs/348.out.bad)
>>     --- tests/xfs/348.out       2017-10-19 10:57:22.561819578 -0700
>>     +++ /root/xfstests/xfstests-dev/results//xfs/348.out.bad
>> 2018-05-21 17:13:39.171256163 -0700
>>     @@ -239,7 +239,7 @@
>>      would have junked entry "DIR" in directory PARENT_INO
>>      would have junked entry "EMPTY" in directory PARENT_INO
>>      would have junked entry "FIFO" in directory PARENT_INO
>>     -stat: 'SCRATCH_MNT/test/DIR' is a symbolic link
>>     +stat: cannot stat 'SCRATCH_MNT/test/DIR': Structure needs cleaning
> 
> That was fixed in (xfstests) commit 60ba1274f5d79b.
> 
> --D

Ah sorry my bad. Forgot to update my xfstests to the latest.

> 
>>      stat: 'SCRATCH_MNT/test/DATA' is a symbolic link
>>      stat: cannot stat 'SCRATCH_MNT/test/EMPTY': Structure needs cleaning
>>     ...
>>     (Run 'diff -u tests/xfs/348.out
>> /root/xfstests/xfstests-dev/results//xfs/348.out.bad'  to see the entire
>> diff)
>> Ran: xfs/348
>> Failures: xfs/348
>> Failed 1 of 1 tests
>>
>> -- 
>>
>> Dave Jiang
>> Software Engineer, SSG/OTC
>> Intel Corp.
>> dave.jiang@intel.com
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-05-22 15:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-22  0:29 xfs regression Dave Jiang
2018-05-22  1:43 ` Darrick J. Wong
2018-05-22 15:41   ` Dave Jiang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).