From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: sandeen@redhat.com
Cc: linux-xfs@vger.kernel.org
Subject: [PATCH v2 6/9] xfs_spaceman: add a superblock info command
Date: Tue, 22 May 2018 20:32:46 -0700 [thread overview]
Message-ID: <20180523033246.GK14384@magnolia> (raw)
In-Reply-To: <152401956907.13048.9916119316995542280.stgit@magnolia>
From: Darrick J. Wong <darrick.wong@oracle.com>
Add an 'info' command to pretty-print the superblock geometry.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
man/man8/xfs_spaceman.8 | 7 +++
spaceman/Makefile | 2 -
spaceman/info.c | 96 +++++++++++++++++++++++++++++++++++++++++++++++
spaceman/init.c | 1
spaceman/space.h | 1
6 files changed, 111 insertions(+), 6 deletions(-)
create mode 100644 spaceman/info.c
diff --git a/man/man8/xfs_spaceman.8 b/man/man8/xfs_spaceman.8
index e4a9137f..12dd04e4 100644
--- a/man/man8/xfs_spaceman.8
+++ b/man/man8/xfs_spaceman.8
@@ -84,6 +84,13 @@ Display a summary of the free space information found.
.PD
.RE
.TP
+.B info
+Displays selected geometry information about the filesystem.
+The opened file must be a mount point of a XFS filesystem.
+The output will have the same format that
+.BR "xfs_info" "(8)"
+prints when querying a filesystem.
+.TP
.BR "help [ " command " ]"
Display a brief description of one or all commands.
.TP
diff --git a/spaceman/Makefile b/spaceman/Makefile
index 8b310309..c1d903ba 100644
--- a/spaceman/Makefile
+++ b/spaceman/Makefile
@@ -7,7 +7,7 @@ include $(TOPDIR)/include/builddefs
LTCOMMAND = xfs_spaceman
HFILES = init.h space.h
-CFILES = init.c file.c prealloc.c trim.c
+CFILES = info.c init.c file.c prealloc.c trim.c
LLDLIBS = $(LIBXCMD) $(LIBFROG)
LTDEPENDENCIES = $(LIBXCMD) $(LIBFROG)
diff --git a/spaceman/info.c b/spaceman/info.c
new file mode 100644
index 00000000..8889346b
--- /dev/null
+++ b/spaceman/info.c
@@ -0,0 +1,96 @@
+/*
+ * Copyright (C) 2018 Oracle. All Rights Reserved.
+ *
+ * Author: Darrick J. Wong <darrick.wong@oracle.com>
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License
+ * as published by the Free Software Foundation; either version 2
+ * of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it would be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA.
+ */
+#include "libxfs.h"
+#include "command.h"
+#include "init.h"
+#include "path.h"
+#include "space.h"
+#include "fsgeom.h"
+
+static void
+info_help(void)
+{
+ printf(_(
+"\n"
+" Pretty-prints the filesystem geometry as derived from the superblock.\n"
+" The output has the same format as mkfs.xfs, xfs_info, and other utilities.\n"
+" The opened file must be an XFS mount point.\n"
+"\n"
+));
+
+}
+
+static int
+info_f(
+ int argc,
+ char **argv)
+{
+ struct xfs_fsop_geom geo;
+ int error;
+
+ if (fs_table_lookup_mount(file->name) == NULL) {
+ fprintf(stderr, _("%s: Not a XFS mount point.\n"), file->name);
+ return 1;
+ }
+
+ /* get the current filesystem size & geometry */
+ error = ioctl(file->fd, XFS_IOC_FSGEOMETRY, &geo);
+ if (error) {
+ /*
+ * OK, new xfsctl barfed - back off and try earlier version
+ * as we're probably running an older kernel version.
+ * Only field added in the v2 geometry xfsctl is "logsunit"
+ * so we'll zero that out for later display (as zero).
+ */
+ geo.logsunit = 0;
+ error = ioctl(file->fd, XFS_IOC_FSGEOMETRY_V1, &geo);
+ if (error) {
+ fprintf(stderr, _(
+ "%s: cannot determine geometry of filesystem"
+ " mounted at %s: %s\n"),
+ progname, file->name, strerror(errno));
+ exitcode = 1;
+ return 0;
+ }
+ }
+
+ xfs_report_geom(&geo, file->fs_path.fs_name, file->fs_path.fs_log,
+ file->fs_path.fs_rt);
+ return 0;
+}
+
+static const struct cmdinfo info_cmd = {
+ .name = "info",
+ .altname = "i",
+ .cfunc = info_f,
+ .argmin = 0,
+ .argmax = 0,
+ .canpush = 0,
+ .args = NULL,
+ .flags = CMD_FLAG_ONESHOT,
+ .oneline = N_("pretty-print superblock geometry info"),
+ .help = info_help,
+};
+
+void
+info_init(void)
+{
+ add_command(&info_cmd);
+}
diff --git a/spaceman/init.c b/spaceman/init.c
index b3efacef..895504f3 100644
--- a/spaceman/init.c
+++ b/spaceman/init.c
@@ -40,6 +40,7 @@ init_commands(void)
{
print_init();
help_init();
+ info_init();
prealloc_init();
quit_init();
trim_init();
diff --git a/spaceman/space.h b/spaceman/space.h
index 5f4a8a0b..d2a25432 100644
--- a/spaceman/space.h
+++ b/spaceman/space.h
@@ -42,5 +42,6 @@ extern void freesp_init(void);
#else
# define freesp_init() do { } while (0)
#endif
+extern void info_init(void);
#endif /* XFS_SPACEMAN_SPACE_H_ */
next prev parent reply other threads:[~2018-05-23 3:32 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 2:45 [PATCH 0/9] xfsprogs-4.17: geometry refactoring Darrick J. Wong
2018-04-18 2:45 ` [PATCH 1/9] libfrog: move platform specific runtime support code out of libxfs Darrick J. Wong
2018-05-03 18:23 ` Eric Sandeen
2018-04-18 2:45 ` [PATCH 2/9] libfrog: refactor fs geometry printing function Darrick J. Wong
2018-05-03 18:47 ` Eric Sandeen
2018-05-03 21:27 ` Eric Sandeen
2018-05-03 21:35 ` Darrick J. Wong
2018-04-18 2:45 ` [PATCH 3/9] mkfs: use geometry generation / helper functions Darrick J. Wong
2018-05-03 18:52 ` Eric Sandeen
2018-04-18 2:45 ` [PATCH 4/9] xfs_db: add a superblock info command Darrick J. Wong
2018-05-03 20:53 ` Eric Sandeen
2018-05-03 21:44 ` Darrick J. Wong
2018-05-23 3:30 ` [PATCH v2 " Darrick J. Wong
2018-05-23 3:57 ` Allison Henderson
2018-04-18 2:46 ` [PATCH 5/9] xfs_spaceman: print a nicer message when the file path isn't on an xfs Darrick J. Wong
2018-05-03 20:57 ` Eric Sandeen
2018-05-23 3:31 ` [PATCH v2 " Darrick J. Wong
2018-05-23 3:58 ` Allison Henderson
2018-04-18 2:46 ` [PATCH 6/9] xfs_spaceman: add a superblock info command Darrick J. Wong
2018-05-03 21:09 ` Eric Sandeen
2018-05-03 21:39 ` Darrick J. Wong
2018-05-08 15:24 ` Darrick J. Wong
2018-05-23 3:32 ` Darrick J. Wong [this message]
2018-05-23 4:08 ` [PATCH v2 " Allison Henderson
2018-04-18 2:46 ` [PATCH 7/9] xfs_info: move to xfs_spaceman Darrick J. Wong
2018-05-03 21:17 ` Eric Sandeen
2018-05-03 21:48 ` Darrick J. Wong
2018-04-18 2:46 ` [PATCH 8/9] xfs_info: call xfs_db for offline filesystems Darrick J. Wong
2018-05-03 21:22 ` Eric Sandeen
2018-05-03 21:55 ` Darrick J. Wong
2018-05-23 3:33 ` [PATCH v2 " Darrick J. Wong
2018-05-23 4:36 ` Allison Henderson
2018-04-18 2:46 ` [PATCH 9/9] xfs_growfs: refactor geometry reporting Darrick J. Wong
2018-05-03 21:25 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180523033246.GK14384@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox